Use track_tags_changed in the notify osd plugin

[raphael meyer]

I use exaile 0.3.1.1 under ubuntu 10.04 to listen to internet radio (mp3 or aac streams). What I missed was an OSD update, when the the track tags changed. Therefore I modified the notifyosd plugin to implement the track_tags_changed callback.

[Mathias Brodala (mathbr)]

Please re-create the patch so that it applies cleanly with -p0 against the latest trunk.

[raphael meyer (raphael-quazz)]

I created a patch for the latest trunk but I didn't test with a build from trunk.

[Mathias Brodala (mathbr)]

Commited with r3772, thanks.

[Christian Ciach (dereineda)]

I can see the option "On tag change" in the options pane on r3824 and it is checked, but it still doesn't work for me. But it does work when manually applying the patch to the stable version 0.3.2.1.

[Christian Ciach (dereineda)]

You didn't fix it properly! In several places in __init__.py you replaced the depracated "exaile.player" with "player.PLAYER", but you forgot to import "player" from "gl" at line 26. If you change this, the plugin will work properly again.

This said, the option "On tray icon hover" doesn't work for me. I will see if I can fix this.

[Christian Ciach (dereineda)]

I don't want to open another bug for this (call me lazy). The "On tray icon hover" option to display the OSD-notification doesn't work because the info-widget already binds to the GtkStatusIcon on this event. Look in file "xlgui/widgets/info.py" around line 506 (at exaile 0.3.3.0-dev+bzr3829). If this connection is removed, this OSD-notification-plugin works fine.

To be honest, I think the widget is more appealing to most users, so maybe the option to show the OSD-notification on hovering the tray icon should be removed. Or let the user the choice..

[Mathias Brodala (mathbr)]

The missing import was added with r3833.