Ouputmode is used wrong in mainFrame.cpp

Bug #683003 reported by rew
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Hugin
Fix Released
High
Unassigned

Bug Description

I get:

....src/hugin1/hugin/MainFrame.cpp:744: warning: case label value exceeds maximum value for type

742 PanoramaOptions opts = pano.getOptions();
743 switch (opts.outputMode) {
744 case PanoramaOptions::TIFF:
745 case PanoramaOptions::JPEG:
746 case PanoramaOptions::PNG:
747 opts.outputLDRBlended = true;
748 break;
749 default:
750 break;
751 }

The outputMode is defined as a enum that will have the values OUTPUT_LDR or ..HDR . (0 or 1).
The TIFF define is too large because it has value 2. It is ment for the FileFormat element of the structure.

I'm not familiar enough (yet) with the code to implement a patch today.

(Just change outputMode to "outputFormat" ?)
-----------
version: Pre-Release 2010.4.0.1e3fcb26cf9e
OS: Ubuntu-Lucid.

I'm tagging this "triaged" and "high", because I am pretty sure this is definitively wrong.

I would suggest that someone checks his build. Around 65%, mainFrame.cpp is compiled, and the message appears. Please push to "confirmed" once this has been verified to occur with someone else too.

Revision history for this message
rew (r-e-wolff) wrote :

Oops. Of course I am modifying this file when I notice this. I suspect the line numbers are off a few compared to the vanilla version.

Yuv (yuv)
Changed in hugin:
status: Triaged → Confirmed
Revision history for this message
Gerry Patterson (gpatters) wrote :

Fix committed, change-set 4659:5e2111e8c9ac

Changed in hugin:
status: Confirmed → Fix Committed
Yuv (yuv)
Changed in hugin:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.