keryx.conf is not updated when install is moved (v1.0)

[mac9416]

I found this bug by copy/pasting my Keryx 1.0 branch from my home directory to a flash drive. When I went to another machine to create a profile, the profile was created in my home directory instead of on the flash drive.

My branch is at revision 57.

[mac9416 (mac9416)]

Is there any reason all the paths in keryx.conf shouldn't be relative?

[Chris Oliver (excid3)]

Ah good catch. Poorly thought out on my part. So what happens is when Keryx saves the configuration it saves full paths not relative ones (which is what it should). However, I'm not sure how to take the preferences configuration absolute path and convert it to a relative path. Any suggestions? The problem spawns because of the preferences window and GTK returning full paths. Thanks for catching this, glad you've got my back. :D

[mac9416 (mac9416)]

I guess one problem is that you never know whether a user wants the path they set to be relative or absolute.
Another problem may be that GTK overwrites any relative paths in keryx.conf with an absolute path whenever Keryx shuts down. Is that the case?
Perhaps it would be a good idea to drop the GTK file browsing widget and simply ask the user to provide a string. That way they specify whether the path should be relative or absolute.

[Chris Oliver (excid3)]

Are there any cases where the path would need to be absolute? I can only see that possibly from the package version, never in the portable one.

[mac9416 (mac9416)]

Yeah, I agree. It seems that the keryx.conf paths for the portable version should always be relative.

As for the packaged version... Since userboy will probably always be loading profiles from and saving them to different locations (flash drives), he should probably always be prompted where to save to and where to load from. Unless we find some efficient way to scan flash drives for profiles -- then he wouldn't have to be prompted where to load from at least.
Also, what about download location for the packaged version? Should everything be downloaded to ~/Downloads, or we prompt userboy for that location as well? Maybe ask him to choose a download location when Keryx is started for the first time?

Sorry my thoughts are a bit rambling. I'm typing this in a hurry. :-)

[Chris Oliver (excid3)]

I have this defaulting to relative path to the script. This might not work when it's built as a package. Will see what happens when users test it.