soundmanager pushBuffer is inefficient
Bug #682527 reported by
Owen Williams
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
High
|
Owen Williams | ||
1.8 |
Fix Released
|
High
|
Owen Williams | ||
1.9 |
Fix Released
|
High
|
Owen Williams |
Bug Description
Based on gprof data, the pushBuffer function in soundmanager.cpp is inefficient. Calls to chanGroup.
Related branches
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Nice catch Owen! There's an identical loop in SoundDevicePort Audio:: callbackProcess and this inversion was done in trunk, but the pushBuffer version of the loop was not done.
I backported your patch to 1.8 (since we're going to do a 1.8.2) and also backported the SoundDevicePort Audio:: callbackProcess to lp:mixxx/1.8 as well.