widelands

wishlist: Fullscreen toogle also in Menu

Bug #682351 reported by Dirk Stöcker
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Wishlist
Unassigned
widelands build19-rc1

Bug Description

The key <F> only works ingame, but not in settings dialog or elsewhere. This is really disturbing, when you need to switch to the desktop from fullscreen mode, but need to stop the game to do so.

Related branches

lp:~peter.waller/widelands/menu-fullscreen-hotkey
Rejected for merging into lp:widelands
SirVer: Disapprove
Diff: 35 lines (+14/-0)
2 files modified
src/ui_fsmenu/base.cc (+13/-0)
src/ui_fsmenu/base.h (+1/-0)
lp:~widelands-dev/widelands/f_for_fullscreen
GunChleoc: Approve
Tino: Needs Fixing
Diff: 529 lines (+144/-146)
11 files modified
src/editor/editorinteractive.cc (+0/-5)
src/ui_basic/panel.cc (+43/-31)
src/ui_basic/panel.h (+6/-6)
src/ui_fsmenu/base.cc (+15/-33)
src/ui_fsmenu/base.h (+6/-13)
src/ui_fsmenu/intro.cc (+1/-1)
src/wlapplication.cc (+52/-36)
src/wlapplication.h (+17/-12)
src/wui/interactive_base.cc (+4/-1)
src/wui/interactive_player.cc (+0/-4)
src/wui/interactive_spectator.cc (+0/-4)
Revision history for this message
Venatrix (elisabeth) wrote :

That's something I find disturbing, too. I normally start in windowed mode just to have the possibility to switch to another desktop while loading a saved game. Especially in a game with three tribes the animations need a while...

Revision history for this message
SirVer (sirver) wrote :

Fullscreen toogle is officially not supported by SDL and only available in a hackish manner for linux. Some developer fixed it in because he wanted it to. So don't hold your breath on seeing this implemented.

Changed in widelands:
status: New → Confirmed
importance: Undecided → Wishlist
summary: - Fullscreen toggle only possible in game
+ wishlist: Fullscreen toogle under Linux also in Menu
Revision history for this message
Dirk Stöcker (stoecker) wrote : Re: wishlist: Fullscreen toogle under Linux also in Menu

You're sure? I only know another SDL application in Perl, but there fullscreen toggle is part of the SDL (Perl) core.

Revision history for this message
SirVer (sirver) wrote :

Yes.

http://forums.libsdl.org/viewtopic.php?p=3820&sid=b64d92e394ff8d83fa71ecc25990c034

It seems like it has vanished from SDL 1.3, so the functionality will vanish from widelands as well soon.

Revision history for this message
Jens Beyer (qcumber-some) wrote :

Since this is not even possible in future SDL releases (and doesn't work right now in Mac/Win builds anyway), shouldn't we set this bug to Won't fix?

Revision history for this message
SirVer (sirver) wrote :

Well, there is always the possibility to kill and reinitialize the whole graphics system. Toggling would then be possible.

Revision history for this message
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Confirmed → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for widelands because there has been no activity for 60 days.]

Changed in widelands:
status: Incomplete → Expired
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Whether we wish to expand the fullscreen toogle to the main menu as well should probably await the conclusion of bug 536500.

SirVer (sirver)
Changed in widelands:
status: Expired → Won't Fix
Revision history for this message
SirVer (sirver) wrote :

This should be simple after merging https://code.launchpad.net/~widelands-dev/widelands/fix_some_resizing_bugs

Changed in widelands:
status: Won't Fix → Confirmed
SirVer (sirver)
Changed in widelands:
assignee: nobody → SirVer (sirver)
status: Confirmed → In Progress
milestone: none → build19-rc1
summary: - wishlist: Fullscreen toogle under Linux also in Menu
+ wishlist: Fullscreen toogle also in Menu
Revision history for this message
SirVer (sirver) wrote :

Fixed in r7298, but see bug 1398733.

Changed in widelands:
status: In Progress → Fix Committed
assignee: SirVer (sirver) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.