Answer contacts for packages cannot create/edit FAQs

[Curtis Hovey]

Answer contacts for Ubuntu packages cannot create FAQs. There are cases where the link is shown but the user gets an error when creating the FAQ.

    Module lp.answers.browser.question, line 1199, in create_and_link_action
    faq = self.faq_target.newFAQ(
    Unauthorized: (<Distribution 'Ubuntu' (ubuntu)>, 'newFAQ', 'launchpad.Append')

The fix for this may require changing the security checker or distro or faqtarget mixin to get answer contacts differently. For questions, Lp wants the smallest set, but for faqs, Lp wants the largest set.

This is a regression cause to a refactoring to create simple permission types for registry admins.

[Curtis Hovey (sinzui)]

This has been broken for several years. The problem is in the security checker. The checker is based on the question checker (answer_contacts), but the set of permitted user is larger. Distribution users who can edit an FAQ are comprised of distro answer_contacts + the answer_contacts of all the packages.

That is a lot of inTeam() checks across a lot of packages. There is an alternate way to solve this that will involve exactly two queries regardless of the number of packages and answer_contacts. The checker can get the user's direct and indirect questiontargets that the user is an answer contact for and compare them to the context.

faq_target = IFAQTarget(context)
for target in direct_targets + indirect_target:
    if faq_target == IFAQTarget(target):
        return True
return False

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12028 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12028>.