dmedia should use PascalCase for methods, properties and Signals exposed via DBus

Bug #682115 reported by Manish Sinha (मनीष सिन्हा)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Dmedia
Fix Released
Critical
Manish Sinha (मनीष सिन्हा)

Bug Description

If you have a look at Zeitgeist , Telepathy or any other project's DBus naming convention, you might notice that they are all PascalCased.

So dmedia should adhere to this.

Related branches

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

I sent the changes. Please review and try it out whether it works or not

Changed in dmedia:
assignee: nobody → Manish Sinha (manishsinha)
status: New → Confirmed
Changed in dmedia:
importance: Undecided → Critical
milestone: none → 0.2
status: Confirmed → In Progress
Revision history for this message
Jason Gerard DeRose (jderose) wrote :

Okay, everything is PascalCase now, and I changed the method names a bit to make them clearer, more distinct from signal names. The methods are now:

Kill()
Version()
GetExtensions()
StartImport()
StopImport()
ListImports()

And the signals are:

ImportStarted
ImportFinished
ImportProgress

Only other thing I was thinking is that AbortImport() might be clearer than StopImport(), but I'll think on that.

Changed in dmedia:
status: In Progress → Fix Committed
Changed in dmedia:
status: Fix Committed → Fix Released
status: Fix Released → Fix Committed
Changed in dmedia:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.