Duplicity 0.6.11 aborts if RSYNC_RSH not set

[Scott Hannahs]

I tested the update to duplicity 0.6.11 and it aborts. I have been using 0.6.10 with the patch for the rsync backend and was hoping that 0.6.11 would be stable.

Mac OS X 10.6.5

Built with fink for python 2.6

Here is the command line and output, the environment variable RSYNC_RSH is not set

% nice -n19 /sw/bin/duplicity --num-retries 5 --tempdir /var/tmp/duplicity --volsize 250 --asynchronous-upload --encrypt-key XXXXXXXX --sign-key YYYYYYYY --gpg-options=--default-key=XXXXXXXX --force ${HOME}/Documents rsync://<email address hidden>/Documents/
Traceback (most recent call last):
 File "/sw/bin/duplicity", line 1245, in <module>
   with_tempdir(main)
 File "/sw/bin/duplicity", line 1238, in with_tempdir
   fn()
 File "/sw/bin/duplicity", line 1124, in main
   action = commandline.ProcessCommandLine(sys.argv[1:])
 File "/sw/lib/python2.6/site-packages/duplicity/commandline.py", line 927, in ProcessCommandLine
   backup, local_pathname = set_backend(args[0], args[1])
 File "/sw/lib/python2.6/site-packages/duplicity/commandline.py", line 820, in set_backend
   globals.backend = backend.get_backend(bend)
 File "/sw/lib/python2.6/site-packages/duplicity/backend.py", line 153, in get_backend
   return _backends[pu.scheme](pu)
 File "/sw/lib/python2.6/site-packages/duplicity/backends/rsyncbackend.py", line 52, in __init__
   del os.environ['RSYNC_RSH']
 File "/sw/lib/python2.6/os.py", line 496, in __delitem__
   del self.data[key]
KeyError: 'RSYNC_RSH'

[Michael Terry (mterry)]

Would this do the trick?

[edso (ed.so)]

Thanks mt, would have done nothing else...

Sorry scott about the issue. Aside from the problems with 0.6.10 there arose new issues with rsync 3.0.7. You stumbled over a part of this fix, that should be fixed with the patch above.

..ede/duply.net

PS: Should we mail ken on the list or setup a branch reflecting the fix?

[edso (ed.so)]

Btw. for all afected from this.

Workaround until fix is upstream:
Please set RSYNC_RSH env var prior running duplicity as a workaround.

..ede/duply.net

[Kenneth Loafman (kenneth-loafman)]

On Sat, Nov 27, 2010 at 4:52 AM, edso <email address hidden> wrote:

> Thanks mt, would have done nothing else...
>
> Sorry scott about the issue. Aside from the problems with 0.6.10 there
> arose new issues with rsync 3.0.7. You stumbled over a part of this fix,
> that should be fixed with the patch above.
>
> ..ede/duply.net
>
> PS: Should we mail ken on the list or setup a branch reflecting the fix?
>

No need to mail me. I saw it. The patch is clean.

I need to fix the test environment as well.

...Ken

[Scott Hannahs (shannahs)]

The patch works for me. I will update the fink installation package with that patch. I will look to see if there are other significant patches that should be included in the fink package.

-sth