confirmation messages not set for translation

Bug #681889 reported by Margarita Manterola
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo GTK Client (MOVED TO GITHUB)
Status tracked in Trunk
5.0
Won't Fix
Undecided
Unassigned
Trunk
Fix Released
Low
OpenERP sa GTK client R&D

Bug Description

In openerp-client/widget/view/form_gtk/one2many_list.py

There are the following lines:

            if self.screen.current_view.view_type == 'form':
                msg = 'Are you sure to remove this record ?'
            else:
                msg = 'Are you sure to remove those records ?'

As it's shown in this code, these lines are not set for translation, they should be enclosed with _() in order for them to get translated.

Related branches

Revision history for this message
Margarita Manterola (marga) wrote :

Just to say that I checked and this bug IS STILL PRESENT in version 6.0

Revision history for this message
Margarita Manterola (marga) wrote :

I'm attaching a patch that adds the possiblity of translation for the messages mentioned.

Even though I did it for a 5.0.X client, it the code in the 6.0 series hasn't changed for this, so it should apply there as well.

Please remember to do whatever you have to do to notify translators after it's applied.

Revision history for this message
Jamin Shah(OpenERP) (jamin-openerp) wrote :

Hello,

This is not a blocking point so this has to be set as Won't Fix for stable.

Thanks

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello Margarita Manterola,

Thanks for patch and the report. It has been applied in lp:~openerp-dev/openobject-client/trunk-dev-client
with revision-info as 1388 <email address hidden>
and will be merged soon to the trunk client.

Thanks,

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.