[edgy] Firefox applications icon inconsistent.

Bug #68180 reported by Scott Robinson
106
Affects Status Importance Assigned to Milestone
firefox (Ubuntu)
Fix Released
Low
Kees Cook
Edgy
Fix Released
Low
Kees Cook
mozilla-thunderbird (Ubuntu)
Invalid
Undecided
Unassigned
Edgy
Invalid
Undecided
Unassigned

Bug Description

The official icon is used in the .desktop file / application launchers / etc. This is correct as per the recent update and announcement on ubuntu-devel.

However, once the program is running, the unofficial globe icon is used for the application icon.

This seems to be an inconsistency.

Revision history for this message
Luka Renko (lure) wrote :

Confirmed

Changed in firefox:
importance: Undecided → Low
status: Unconfirmed → Confirmed
Revision history for this message
Matt Zimmerman (mdz) wrote :

This minor change should be rolled into the first firefox update for edgy. The trouble is that debian/rules overrides the icon provided; if that code is removed then this should work correctly now (the icon has been patched back in)

Changed in firefox:
assignee: nobody → pitti
Revision history for this message
jvargas (vargas) wrote :

Confirmed @ Edgy.

Revision history for this message
Tom Harris (tom-harris) wrote :

Still not fixed in Edgy as of 19th November. I'm not a programmer - can anyone patch this?

Revision history for this message
Matt Zimmerman (mdz) wrote : Re: [Bug 68180] Re: [edgy] Firefox application icon inconsistent.

On Sun, Nov 19, 2006 at 06:16:28PM -0000, Tom wrote:
> Still not fixed in Edgy as of 19th November. I'm not a programmer - can
> anyone patch this?

It's trivial to fix, but we aren't going to release an update to a stable
release only for a cosmetic bug. It will be rolled into the first
bugfix/security update we do.

--
 - mdz

Revision history for this message
Tom Harris (tom-harris) wrote : Re: [edgy] Firefox application icon inconsistent.

Great! I wasn't sure if there had been any updates for Firefox yet. Thanks for the swift response!

Revision history for this message
Matt Zimmerman (mdz) wrote :

Kees, was this rolled into USN-381-1? If not, please issue a further update with this change.

Revision history for this message
Jonh Wendell (wendell) wrote :

Matt, the USN-381-1 update refers 1.5 version, not 2.0 (edgy).

Revision history for this message
Kees Cook (kees) wrote :

Matt, Jonh is correct, USN-381-1 is only for the 1.5 (non-edgy) series. When the 2.0 updates happen, we'll be sure to get this change in. Does anyone have the desired patch handy?

Revision history for this message
Matt Zimmerman (mdz) wrote : Re: [Bug 68180] Re: [edgy] Firefox application icon inconsistent.

On Tue, Nov 21, 2006 at 08:10:38PM -0000, Kees Cook wrote:
> Matt, Jonh is correct, USN-381-1 is only for the 1.5 (non-edgy) series.
> When the 2.0 updates happen, we'll be sure to get this change in. Does
> anyone have the desired patch handy?

No, but I think that it should be as simple as removing a few lines from
debian/rules so that the icons aren't clobbered. I believe the relevant
code is in the install target:

        cp -a debian/firefox.xpm \
                debian/firefox/usr/share/pixmaps/mozilla-firefox.xpm
        cp -f debian/firefox.xpm \
                debian/firefox/usr/share/firefox/icons/default.xpm
        cp -f debian/firefox.xpm \
                debian/firefox/usr/share/firefox/icons/mozicon50.xpm
        cp -f debian/firefox-small.xpm \
                debian/firefox/usr/share/firefox/icons/mozicon16.xpm
        cp -a debian/firefox.xpm \
                debian/firefox/$(SHARE_DIR)/chrome/icons/default/default.xpm

The source tree is already patched at build time to restore the upstream
icons, and they should be installed properly already.

--
 - mdz

Revision history for this message
Marco Cimmino (cimmo) wrote : Re: [edgy] Firefox application icon inconsistent.

this affects also thunderbird isn't?

Revision history for this message
Someone (s4910321931-deactivatedaccount) wrote :

And what about feisty? Can it be posted with trademarked icon on the taskbar?

Marco Cimmino (cimmo)
Changed in mozilla-thunderbird:
status: Unconfirmed → Confirmed
Revision history for this message
Matt Zimmerman (mdz) wrote : Re: [Bug 68180] Re: [edgy] Firefox application icon inconsistent.

On Sun, Nov 26, 2006 at 04:24:22PM -0000, Cimmo wrote:
> ** Also affects: mozilla-thunderbird (Ubuntu)
> Importance: Undecided
> Status: Unconfirmed

This is a separate issue; Thunderbird doesn't use the official branding at
all yet, I don't think.

--
 - mdz

Revision history for this message
Marco Cimmino (cimmo) wrote : Re: [edgy] Firefox and Thunderbird applications icon inconsistent.

no?
The desktop icon is the official one and it is different from the icon inside thunderbird

Revision history for this message
Bloodypriest (jeanmichel-gilbert) wrote :

As of December 3, Firefox 2.0 in Edgy does not exhibit this problem. However, in Thunderbird case, neither the .desktop icon nor the icon inside the application are using the official artwork; only the ugly brownish letter icon. This is Thunderbird 1.5.0.8 (20061115) from edgy.

Revision history for this message
Bloodypriest (jeanmichel-gilbert) wrote :

Forget what I said. I confused the .desktop icons with the application launchers. In the Human theme, Firefox still has some icons exhibiting blue globes (for instance, the HTML document icon).

Revision history for this message
Matt Zimmerman (mdz) wrote :

Thunderbird is an entirely separate issue; rejecting that task from this bug. Feel free to file a separate bug about official branding in Thunderbird, but that has not yet been discussed with Mozilla.

Please only use this bug report to discuss the inconsistent icons in Firefox.

Changed in mozilla-thunderbird:
status: Confirmed → Rejected
Martin Pitt (pitti)
Changed in firefox:
status: Confirmed → In Progress
Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

Can't this bug be solved on Feisty? There isn't any problem on having an update since it is in development.

Revision history for this message
Matt Zimmerman (mdz) wrote : Re: [Bug 68180] Re: [edgy] Firefox applications icon inconsistent.

On Sun, Dec 17, 2006 at 09:29:11PM -0000, Emilio Pozuelo wrote:
> Can't this bug be solved on Feisty? There isn't any problem on having an
> update since it is in development.

Yes, it certainly can.

--
 - mdz

Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

By Matt Zimmerman
>Yes, it certainly can.

And would it be solved? If it is possible, why not do it now?

Regards
Pochu

Revision history for this message
Matt Zimmerman (mdz) wrote :

On Mon, Dec 18, 2006 at 12:45:17AM -0000, Emilio Pozuelo wrote:
> By Matt Zimmerman
> >Yes, it certainly can.
>
> And would it be solved? If it is possible, why not do it now?

It simply hasn't been done yet, as evidenced by the fact that this bug
remains open. Thanks for your interest in this bug report, but it is a
cosmetic problem, and thus is not an urgent priority relative to other bugs
in Ubuntu. It should be dealt with when the Firefox package is next updated
in Feisty.

Until then, please keep commentary in this bug report to a minimum. The
problem is already well understood and no further discussion is necessary.

--
 - mdz

Revision history for this message
Marco Cimmino (cimmo) wrote :

firefox 2.0.0.1 is out, there is the possibility to fix this bug also for Edgy.
Don't want to bother just remembered :)

Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

Yes, here you can get it (as mozilla.org hasn't been updated yet).

http://releases.mozilla.org/pub/mozilla.org/firefox/releases/2.0.0.1/

Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

Fixed on repos

Good job!

Changed in firefox:
status: In Progress → Fix Released
Kees Cook (kees)
Changed in firefox:
assignee: pitti → keescook
Changed in mozilla-thunderbird:
status: Unconfirmed → Rejected
Changed in firefox:
assignee: nobody → keescook
status: Unconfirmed → Fix Committed
importance: Undecided → Low
Revision history for this message
Kees Cook (kees) wrote :

Edgy's update was done as part of USN-398-1

Changed in firefox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.