Log super-fast import timeouts

Bug #680802 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

We regularly either have problems with the super-fast imports, or suspect we have problems with super-fast imports but aren't really sure.

We should log timeouts in ExistingPOFileInDatabase, so we know when this happens. The Recife model makes this cache a lot simpler, so the problem may just disappear.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Ah, just found that there is a unit test for this class. The absence of the class from its __all__ misled me (the test imports it even though it's not in __all__). We do seem to need more thorough testing though, and some form of notification about the timeouts.

summary: - Unit-test super-fast imports
+ Log super-fast import timeouts
description: updated
Revision history for this message
Данило Шеган (danilo) wrote :

Do scripts actually have timeouts?

Changed in rosetta:
status: New → Incomplete
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Most don't, but this one does. Somebody called Danilo something-or-other added a query timeout in ExistingPOFileInDatabase to stop a particular operational problem we were having at the time.

Revision history for this message
Данило Шеган (danilo) wrote :

Damn that guy.

Though indeed, it'd probably be good to log that one. Not sure how'd we tie it in into the regular timeout infrastructure (if at all), but it'd be good to know when this query starts failing.

Changed in rosetta:
status: Incomplete → Triaged
importance: Undecided → Low
tags: added: tech-debt
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

In this particular case I wouldn't invest into fancy reporting just yet. The Recife change may have eliminated any remaining instances of the timeout.

I'd just log a message, let the thing run for a while, and then see what follow-up is appropriate. Chances are that either we can remove the query timeout now, or we'll find it easier to diagnose the problem.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.