Checkout override dialog includes "(Unexpected error: payload not available)"

[Dan Scott]

  * Evergreen trunk r18828
  * OpenSRF 1.6.1

Trying to check out an item that is in the "In Process" status correctly displays the "Override Checkout Failure?" dialog, but the text displayed in the dialog under the "Exceptions" heading says:

"""
COPY_NOT_AVAILABLE copy not available: (Unexpected error: payload not available)
Copy is not available
"""

You can click "Yes" to force the override, as expected, but the "Unexpected error: payload not available" text appears to be a raw exception leaking through.

[Jason Etheridge (phasefx)]

> Checkout override dialog includes "(Unexpected error: payload not available)"

There used to be a payload here, but I bet it disappeared with the
rise of in-db circ and the more recent fail_part work. :-(

[Dan Scott (denials)]

Okay. Worked out that the actual error text comes from Open-ILS/xul/staff_client/server/circ/checkout.js line 646, now to work backwards to figure out what changed and how to fix it :)

[Dan Scott (denials)]

So - the payload in r.payload was an acp object, and the status() method used to return a fleshed ccs object, but at some point that changed to just the status ID. Which meant that calling the name() function on the raw integer made JavaScript unhappy and triggered the error message and subsequent exception.

Which Jason's help, I was able to reconstitute the status name and provide the expected text to the override dialogue in the COPY_NOT_AVAILABLE case and checked the fix into trunk in r18897 and backported the fix to rel_2_0.