bzr whoami should print error if both username and --email were specified
Bug #680449 reported by
Paul Sladen
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Low
|
Jelmer Vernooij |
Bug Description
Doing:
bzr whoami --email <email address hidden> 'Paul Sladen'
bzr whoami 'Paul Sladen' --email <email address hidden>
both give an error:
bzr: ERROR: extra argument to command whoami:
Okay, fair enough, lets let them one-by-one:
bzr whoami --email <email address hidden>
however, the output from:
bzr whoami
<email address hidden>
then shows that both the clear name and email have been set, despite only being passed --email.
Ideally input and output would have self-consistency.
Related branches
lp:~jelmer/bzr/whoami-conflict-email-identity
- John A Meinel: Approve
-
Diff: 55 lines (+12/-3)3 files modifiedbzrlib/builtins.py (+4/-0)
bzrlib/tests/blackbox/test_whoami.py (+5/-3)
doc/en/release-notes/bzr-2.4.txt (+3/-0)
Changed in bzr: | |
status: | Confirmed → In Progress |
assignee: | nobody → Jelmer Vernooij (jelmer) |
Changed in bzr: | |
status: | In Progress → Fix Released |
milestone: | none → 2.4b1 |
To post a comment you must log in.
As indicated by --help, "bzr whoami --email" will only extract and print the current users email address.
"bzr whoami 'Paul Sladen <email address hidden>'" should set your identity.
"bzr whoami --email <email address hidden>" should print an error rather than ignoring --email as it seems to do at the moment.