fix bug #1914272: missing -lpthread in matchpoint

[Lukas Jirkovsky]

Attached patch adds -lpthread linker flag to matchpoint when gcc is used. Solves bug #1914272.

[Lukas Jirkovsky (l-jirkovsky)]

The file matchpoint_lpthread.patch was added: patch against rev 2978

[Lukas Jirkovsky (l-jirkovsky)]

Logged In: YES
user_id=2036447
Originator: YES

New patch:
Changed patch to add -lpthread flag according to pthread header existence. That's because gcc can be used on platform that doesn't use posix thread model so this way should be safer.
File Added: matchpoint_lpthread_new.patch

[Lukas Jirkovsky (l-jirkovsky)]

The file matchpoint_lpthread_new.patch was added: new patch using header control

[Lukas Jirkovsky (l-jirkovsky)]

Logged In: YES
user_id=2036447
Originator: YES

Third version:
Uses control if system is Unix. I really don't know which way is the best, but all of them are working.
File Added: matchpoint_lpthread_unix.patch

[Lukas Jirkovsky (l-jirkovsky)]

The file matchpoint_lpthread_unix.patch was added: patch using system control

[Pablo d'Angelo (pablo.dangelo)]

Logged In: YES
user_id=30308
Originator: NO

Quick note:

I think the source of the problem is the CMake OpenEXR detection script (which should add -lpthread, if it is needed OpenEXR 1.5.0 and later) and needs to be fixed there.

ciao
  Pablo

[Lukas Jirkovsky (l-jirkovsky)]

Logged In: YES
user_id=2036447
Originator: YES

This is a little bit tricky:

$ pkg-config --libs OpenEXR
-lIlmImf -lImath -lHalf -lIex -lz

$ pkg-config --cflags OpenEXR
-pthread -I/usr/include/OpenEXR

I've found, that it's bug of OpenEXR 1.4.0 (and maybe others):
http://savannah.nongnu.org/bugs/?func=detailitem&item_id=18233

I'm working on patch, which adds -lpthread when old OpenEXR version is used.

[Lukas Jirkovsky (l-jirkovsky)]

Logged In: YES
user_id=2036447
Originator: YES

I've done patch, which adds -lpthread manually when old (OpenEXR<1.5.0) OpenEXR is used.
Please be patient with me, because I've never worked with cmake before.
File Added: bad_openexr_hack.patch

[Lukas Jirkovsky (l-jirkovsky)]

The file bad_openexr_hack.patch was added: OpenEXR detection workarround

[Lukas Jirkovsky (l-jirkovsky)]

Logged In: YES
user_id=2036447
Originator: YES

New info:
The problem persists also in newest stable version of OpenEXR, which makes previous patch unusable.

[Yuv (yuv)]

Logged In: YES
user_id=1347188
Originator: NO

thank you for your effort, Lukas.

I see a newer bug report on this issue was filed anonymously:

<http://savannah.nongnu.org/bugs/?22822>

is it you? if not, and if you have a login there, vote for it to be fixed. I did.

How familiar are you with the OpenEXR project / codebase ?

I'd hate to see you go working for another project, but maybe the fix for this is on the OpenEXR side of things and not on the hugin side of things? If you decide to go down that avenue and fix OpenEXR, I would appreciate you coming back to hugin after the fix :-)

[Lukas Jirkovsky (l-jirkovsky)]

Logged In: YES
user_id=2036447
Originator: YES

Yeah, that's my bug report :-)

Actually, I'm not familiar with OpenEXR in any way except this.