control points tab ignores keyboard shortcuts

[jzander]

Keyboard commands like 0,1,2,f,g won't work in the OS X builds (on a dual G5, running 10.4.11). This has not worked under any version of Hugin I have tested, including the latest RCs and revision 3455.

After digging around a bit I found a special case in file CPImageCtrl.cpp on line 1325, that excludes event processing on the mac with an #indef. After commenting out the #ifndef/#endif, everything works as expected. I have no idea why this block had been special-cased in the first place but it seems that this is not needed anymore.

[ippei (ippei)]

I can't find any reason if it works.
It seems there used to be a bug to work around.

http://hugin.svn.sourceforge.net/viewvc/hugin?view=rev&revision=1732

[ippei (ippei)]

Unfortunately the workaround seems still necessary. Most likely something inside wxMac again.
I'll keep this item open for later.

[Bruno Postle (brunopostle)]

Actually the Control Points tab keyboard shortcuts are broken on Linux too with both 0.7.0 and the current trunk

[Gerry Patterson (gpatters)]

Hello,

The keyboard shortcuts work for me under linux (Kubuntu 9.04 i386).

[Yuv (yuv)]

can an OSX user confirm if the keyboard shortcuts 0,1,2,f,g on the Control Points tab are broken in a recent OSX build? And maybe a Windows user too? The keyboard shortcuts work for me in 2010.4.0 (kubuntu 10.04 AMD64).

[zarl (carl-einem)]

I had to look up the shortcuts here first: <http://wiki.panotools.org/Hugin_Control_Points_tab#Keyboard_shortcuts>

So, on OS X 10.4 / hugin 2010.5.0.4854:d29b1d6da0e0 built by Harry van der Wolf / large aluminum keyboard
'a' works (just a test)
zooming with '0' or '1' doesn't work (on both the upper number keys and the extra number block on the right)
What is '2' supposed to do? This is not yet described in the wiki.
'f' doesn't work
'g' doesn't seem to do anything (it's experimental, right?)

[Yuv (yuv)]

Thank you for testing, Carl.

I set the status to New since there is new information to be evaluated/triaged.

[Yuv (yuv)]

All mentioned shortcuts work on the latest Linux version.
'2' looks like 200% scaling.
'g' prompts a series of parameters for the CP generation.

[Yuv (yuv)]

Tried to fix it in 4984:ca93acae60e3 - can a Mac User build and test?

[zarl (carl-einem)]

Shortcuts for Zoom worked on OS X in prior versions to 2014.0.0 with cmd+0|1|2, now in

2014.0.0-beta1 built by Matthieu DESILE
Mac OS X 10.6 or 10.8

I tested all available modifier key combinations as well as just simple 0|1|2, but nothing happens.