log the time db patch application takes in developer accessible location

[Robert Collins]

I realise that this is /very close/ to being a duplicate, but I wanted a single clear statement of what we need.

We need to record somewhere where developers can access it, how long each DB patch takes to apply. Recording in a log file that is rsynced to devpad would be fine.

This is important (e.g. before the release in december) because we need this to QA db patches as part of continuous deployment; moving to an incremental fashion there matters because its a prerequisite for safely merging db-devel to devel pre-release - and that matters because the qa toolchain functions better if we keep just one branch deployed.

[Gary Poster (gary)]

I think Robert is talking about bug 368600, which Stuart closed as Won't Fix. I like this proposed change.

[Stuart Bishop (stub)]

I've added the patch timings to security.py output, code currently in review.

Once this lands, developers can see the output buried in /srv/launchpad.net-logs/staging/sourcherry/[...]-staging-restore.log

To make this more accessible, we can update the staging update script to run upgrade.py using an argument like the following to spool its output separately:

./upgrade.py --log-file=INFO:/srv/staging-logs/dbupgrade.log

[Robert Collins (lifeless)]

\o/

[Launchpad QA Bot (lpqabot)]

Fixed in db-stable r9997 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/9997>.

[Gary Poster (gary)]

Could Stuart or a LOSA ack that the message to use ``./upgrade.py --log-file=INFO:/srv/staging-logs/dbupgrade.log`` has been successfully passed on to the LOSAs? I'd be happy to send an RT if it had not been done yet.

[Launchpad QA Bot (lpqabot)]

Fixed in db-stable r10034 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/10034>.

[Stuart Bishop (stub)]

For Gary's request on logging the information to a separate log file,

Full rebuild logging to the dbupgrade.log is at https://code.launchpad.net/~stub/launchpad/pending-db-changes/+merge/44198

Upgrade only update is at https://code.launchpad.net/~stub/lp-staging-scripts/devel/+merge/44200

[Launchpad QA Bot (lpqabot)]

Fixed in db-stable r10080 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/10080>.