Campaign dialogs should be tall enough to fit images to avoid scrollbars with short text

[Hans Joachim Desserud]

Bug 677314 got me thinking. I've noticed that even when the text is short enough to fit within the campaign briefing dialog, a scrollbar is added since the portrait is taller than the dialog window. I think, optimally, the scrollbar should only be shown if the text is to long to show all of it at once.
I looked through the portraits, and as I suspected they share the same size. So if the dialog's height was increased to contain the portrait*, short texts could be shown without scrollbars. I am aware that a few briefings have the headline covering two lines, which of course would cause a scrollbar nonetheless.

*The other solution would of course be to resize the portrait images, though I like the former solution better.

[Hans Joachim Desserud (hjd)]

See example in the attached screenshot. When scrolling down, no additional text is revealed, only the bottom of the portrait.

[SirVer (sirver)]

Could you check if the atlantean mission is more to your liking? we can adjust the window size to this then.

[Chuck Wilder (chuckw20)]

Reducing the height of the portrait images would be the quickest and easiest solution to the issue. I have no problem with that as long as long as the faces remain the size they are currently... (and they remain stationary if the text must scroll.) ;)

[SirVer (sirver)]

I disagree. I think the op is happy with how it is done in the atlantean scenario. If so, increasing the dialog box heiht by a few pixels is easiest, prettiest and trivial.

[Chuck Wilder (chuckw20)]

I have no strong opinion actually. Just offering to adjust the graphic images if/where it is desired. :)

[Hans Joachim Desserud (hjd)]

SirVer: I haven't had the time to play through the entire Atlantean mission yet, but they seem to fit the portraits better. Though they almost seem a bit too tall (I'm not sure if this is to leave room for double headlines? I'm sorry I can't make my mind up :) ).
Another thing, when the dialogs have different size in the Atlantean mission, is this set for each mission (/each dialog)? Shouldn't it rather be one standard size for all dialogs, to keep them consistent? I experimented a bit with some of the other missions, but I couldn't really figure out how to change the size of them.

Chuck: While resizing the images is probably the quickest fix, I don't really see it as the best fix. IMO the problem is more "the dialogs are too tiny" rather than "the portraits are too big". I also like the size/ratio of the portraits like they are currently.

[SirVer (sirver)]

fixed in r5888

[SirVer (sirver)]

Released in build16-rc1