resubmitting a merge proposal should reuse the old commit message
Bug #676769 reported by
Andrew Bennetts
This bug affects 7 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Kit Randel | ||
Bug Description
To reproduce:
* make a merge proposal, give it a commit message.
* resubmit that proposal
* observe that the new proposal has no commit message.
I'd expect that either:
1. the commit message is preserved in the new proposal, or
2. the resubmit workflow would offer me the chance edit the commit message (and description) for the new proposal (defaulting to the message from the first original proposal).
Instead I have to notice that the commit message was forgotten, find the link to the old proposal, and copy-and-paste it from there. As a perhaps interesting data point I often want to update the description when resubmitting, but so far I've always wanted to use the commit message I already wrote as-is.
Related branches
lp:~blr/launchpad/recycle-commit-message
- William Grant: Approve (code)
-
Diff: 204 lines (+36/-12)6 files modifiedlib/lp/code/browser/branchmergeproposal.py (+3/-1)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+5/-0)
lib/lp/code/interfaces/branchmergeproposal.py (+4/-1)
lib/lp/code/model/branchmergeproposal.py (+5/-2)
lib/lp/code/model/tests/test_branchmergeproposal.py (+7/-0)
lib/lp/testing/factory.py (+12/-8)
| tags: | added: code-review confusing-ui |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| Changed in launchpad: | |
| importance: | Medium → Low |
Revision history for this message
| Andrew Starr-Bochicchio (andrewsomething) wrote | #1 |
| Changed in launchpad: | |
| assignee: | nobody → Bayard 'kit' Randel (blr) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is particularly frustrating as a lot of the Ubuntu-related projects' CI fails when there is no commit message.