Posting on my wall throws errors

[Charlie Amoah]

Hi I just posted on my wall the text: "I am posting on my wall" then proceeded to click on the save button. I got the following:

1: A message that: the "Post added successfully"

2: An error that: the "Mahara: Master Branch: Site unavailable
A nonrecoverable error occured. This probably means you have encountered a bug in the system

3: I then pressed the back button to check my wall the text: "I am posting on my wall" was still in the text field and nothing had been posted

Mahara Master Dev

On Windows & Linux

Postgres

IE8 & FF3

[Charlie Amoah (charlie-catalyst)]

Correction: the last comment happened in IE

[Richard Mansfield (richard-mansfield)]

Relevant bit from the log:

[WAR] 34 (lib/errors.php:462) An exception was thrown of class PieformException.
[WAR] 34 (lib/errors.php:462) THIS IS BAD and should be changed to something extending MaharaException,
[WAR] 34 (lib/errors.php:462) unless the exception is from a third party library.
[WAR] 34 (lib/errors.php:462) Original trace follows
[WAR] 34 (lib/pieforms/pieform.php:520) Your wallpost_2735_submit function should use $form->reply to send a response, which should redirect or exit when it is done. Perhaps you want to make your reply callback do this?
Call stack (most recent first):
  * Pieform->__construct(array(size 9)) at /htdocs/lib/pieforms/pieform.php:161
  * Pieform::process(array(size 9)) at /htdocs/lib/pieforms/pieform.php:71
  * pieform(array(size 9)) at /htdocs/blocktype/wall/lib.php:185
  * PluginBlocktypeWall::wallpost_form(object(BlockInstance)) at /htdocs/blocktype/wall/lib.php:62
  * PluginBlocktypeWall::render_instance(object(BlockInstance)) at Unknown:0
  * call_user_func_array(array(size 2), array(size 1)) at /htdocs/lib/mahara.php:1176
  * call_static_method("PluginBlocktypeWall", "render_instance", object(BlockInstance)) at /htdocs/blocktype/lib.php:658
  * BlockInstance->render_viewing() at /htdocs/lib/view.php:1184
  * View->build_column(2, false) at /htdocs/lib/view.php:1152
  * View->build_columns() at /htdocs/user/view.php:310

[Ruslan Kabalin (rkabalin)]

Fixed.
There were two reasons:
    * pieform.js is not included in user/view.php
    * when javascript is disabled, there is no proper redirect from wallpost_submit.

[Richard Mansfield (richard-mansfield)]

Ruslan, I just got a redirect error when posting with javascript disabled, and found this bug report. I think commit 6415c6bf56 broke it.

[Melissa Draper (melissa)]

https://reviews.mahara.org/646 has been pushed to revert the 6415c6bf56

[Ruslan Kabalin (rkabalin)]

> I think commit 6415c6bf56 broke it.
Yeah, feel free to revert it. I am not sure why I removed it on the first instance, probably for cosmetic reason.