Error processing in blocktype config window
Bug #675564 reported by
Ruslan Kabalin
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Ruslan Kabalin |
Bug Description
As it was pointed out in https:/
Brief investigation has shown that even if form processing ever ends with any of feed URL failure, no detailed information about the error apart of standard pieform error header (i.e. "...Please check the marked fields and try again") in the main window (as block config form is closed by that time) is displayed.
Changed in mahara: | |
status: | New → Confirmed |
assignee: | nobody → Ruslan Kabalin (ruslan-kabalin) |
summary: |
- Error processing in External feed blocktype + Error processing in blocktype config window |
Changed in mahara: | |
milestone: | none → 1.4.0 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
There are two causes of this bug has been fixed:
1. Form validation method does not handle XML_Feed_ Parser_ Exception (b63f327630)
2. Curl default time-out of 60 sec might be too log and make user think that from processing "is frozen" (63b3d9ad54)
Though one problem is still there. We have to decide whether we want to close block config window in case of failure (such as XML_Feed_ Parser_ Exception) . If we need to close it, I will make changes so that error text will be propagated to the main window and be shown instead of "Please check the marked fields and try again". If the block config window should rather remain open and error displayed under URL field, then f032d6f1d9 fix has to be revised as currently it causes block config window to be closed and general form error displayed in the main window.