Attempt to set-up a MasterPolicyDB policy should fail when in read-only mode

[Francis J. Lacoste]

AFAIU, it is still possible to set-up a MasterPolicy policy when the app servers are in read-only mode. This would occur for example if a request to the private XML-RPC end-point is made while in read-only mode.

This will still fail as the master won't be reachable, or the connection will be killed when the DB is restarted.

We are still disabling client services when doing an upgrade, so the risk of this happening is limited and the consequences might be relatively minor.

But I think it would be safer to fail early and cleanly in that case.

[Robert Collins (lifeless)]

We change the db server to reject connections, so this will definitely fail. However I agree that doing the change suggested here would be safer and is important to do.

[Stuart Bishop (stub)]

We can make BaseDatabasePolicy.getStore() raise ReadOnlyModeDisallowedStore if a request for a master store is made while in read only mode.

[Robert Collins (lifeless)]

On Tue, Nov 16, 2010 at 5:27 PM, Stuart Bishop
<email address hidden> wrote:
> We can make BaseDatabasePolicy.getStore() raise
> ReadOnlyModeDisallowedStore if a request for a master store is made
> while in read only mode.

Please!

[Launchpad QA Bot (lpqabot)]

Fixed in stable r11932 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11932>.

[Robert Collins (lifeless)]

This would be testing a negative - its a belts and bracers helper.