testtools.tests.test_content.TestBytesContent.test_bytes fails on Python 3
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
testtools |
Fix Released
|
Critical
|
Martin Packman |
Bug Description
A new test added in r128 seems to have exposed an existing Python 3 issue, and fails:
=======
ERROR: testtools.
-------
Text attachment: traceback
------------
Traceback (most recent call last):
File "testtools\
return fn(*args)
File "testtools\
return self._get_
File "testtools\
self.
File "testtools\
self.
File "testtools\
mismatch = matcher.
File "testtools\
if self.comparator
File "testtools\
''.
TypeError: sequence item 0: expected str instance, bytes found
------------
Can't be using str.join for bytes on Pythons where str is a unicode type.
Related branches
- testtools developers: Pending requested
-
Diff: 73 lines (+18/-8)2 files modifiedtesttools/content.py (+5/-2)
testtools/tests/test_content.py (+13/-6)
Changed in testtools: | |
assignee: | nobody → Martin [gz] (gz) |
status: | New → In Progress |
Changed in testtools: | |
status: | In Progress → Fix Committed |
importance: | Undecided → High |
milestone: | none → next |
Changed in testtools: | |
importance: | High → Critical |
Changed in testtools: | |
status: | Fix Committed → Fix Released |