VM

vm-previous-message regression in mbox mode

Bug #674383 reported by sujith_m82
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
VM
Fix Released
Low
sujith_m82

Bug Description

In summary mode, sometimes the message is not fontified, i.e., the colors are absent, when using vm-previous-message (keymapping: "p").
Moving to the next message and then back to the previous one fixes it, and the message is now colorized properly. This behaviour is random, but easily reproducible. This issue was not seen when I used the 8.0.x releases ...

My Emacs version: GNU Emacs 23.2.1
VM: 8.1.93a ( I tried with trunk too, the issue is sill present )

I have this in my .emacs:

(add-hook 'vm-summary-mode-hook 'u-vm-color-summary-mode)
(add-hook 'vm-select-message-hook 'u-vm-color-fontify-buffer)
(defadvice vm-decode-mime-message (after u-vm-color activate)
  (u-vm-color-fontify-buffer-even-more))

Tags: maint

Related branches

Revision history for this message
Uday Reddy (reddyuday) wrote : Re: [Bug 674383] [NEW] vm-previous-message regression in mbox mode

u-vm-color is a user-contributed library and it is not being
maintained by any one.

However, vm now has vm-summary-faces library integrated into it. So,
there is no need to use u-vm-color for the summary. Please see the
NEWS file and the info manual.

Revision history for this message
sujith_m82 (m-sujith) wrote :

The Summary list is fine, the Presentation buffer for the mail is not being updated properly.
I used vm-summary-faces instead of u-vm-color and the summary is colorized, but the message is not - am I missing something here ?
u-vm-color provides a bunch of faces to tweak ( author, date, recipient, subject, signature ... ), is this provided by VM now ?
Or is there an alternate way to manipulate message faces in the Presentation window ?

Sorry for asking all these questions in the bug report, but digging into the info doc didn't turn up anything. :(

Revision history for this message
Uday Reddy (reddyuday) wrote : [Bug 674383] Re: vm-previous-message regression in mbox mode

sujith_m82 writes:

> I used vm-summary-faces instead of u-vm-color and the summary is
> colorized, but the message is not - am I missing something here ?

No, vm-summary-faces only colors the summary. VM doesn't have any
in-built stuff for coloring the message presentation, other than
headers and URL's.

> Or is there an alternate way to manipulate message faces in the
> Presentation window ?

Not that I know of. If you can use u-vm-color for the message bodies
without using its summary fontification, then please do. If it is
still broken when you try it, I can take a look at it, but I can't
promise that it will be fixed. (That is the point of saying that
u-vm-color is not "maintained".)

Revision history for this message
sujith_m82 (m-sujith) wrote :

Ok, thanks for the explanation.

Revision history for this message
sujith_m82 (m-sujith) wrote :

Ok, I found some time to take a look at this and adding this to my .emacs fixes the issue:

(defadvice vm-show-current-message (after u-vm-color activate)
   (u-vm-color-fontify-buffer-even-more))

The earlier advice for "vm-decode-mime-message" was not being invoked for us-ascii messages, which is why
the fontification wasn't being done.

Revision history for this message
Uday Reddy (reddyuday) wrote :

Hi Sujith, Thanks for the fix and sorry for the delay in getting back.

I have added a comment in the preamble of u-vm-color.el.

Cheers,
Uday

Changed in vm:
importance: Undecided → Low
milestone: none → 8.2.0a
status: New → Fix Committed
tags: added: maint
Changed in vm:
assignee: nobody → sujith_m82 (m-sujith)
Uday Reddy (reddyuday)
Changed in vm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.