ui4.setupdialog.SetupDialog emits SIGNALs the PyQt3 way

Bug #673964 reported by Jiri Popelka
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HPLIP
Fix Released
Undecided
Sarbeswar Meher

Bug Description

Some Fedora users see the following traceback

File "/usr/share/hplip/ui4/setupdialog.py", line 902, in FaxNameLineEdit_textEdited
    (self.PrinterNameLineEdit.text(),))
TypeError: textChanged(QString): argument 1 has unexpected type 'tuple'

I'm not PyQt skilled but when comparing
http://www.riverbankcomputing.co.uk/static/Docs/PyQt3/PyQt.html
and
http://www.riverbankcomputing.co.uk/static/Docs/PyQt4/pyqt4ref.html#emitting-signals
I think the problem is that the signal is emitted the PyQt3 way there.

I'm attaching a patch that I think (I'm not able to reproduce the problem) should fix this.

Revision history for this message
Jiri Popelka (jpopelka) wrote :
Revision history for this message
Jiri Popelka (jpopelka) wrote :
Revision history for this message
Tim Waugh (twaugh) wrote :

The signal names were wrong as well. Replacement patch attached.

Changed in hplip:
assignee: nobody → Sarbeswar Meher (sarbeswar-meher)
Changed in hplip:
status: New → Fix Committed
Revision history for this message
Sarbeswar Meher (sarbeswar-meher) wrote :

Fix is given in HPLIP 3.11.12 which can be downloaded from http://hplipopensource.com/hplip-web/index.html .

Changed in hplip:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.