Server ORM bug V5. Error in read function with inherited field. Maybe V6 is also impacted

[Sébastien BEAU - http://www.akretion.com]

We are working on product_variant_multi and so using inherited fields.

If you add the field "name" to the object product.product, the "read" function on the object product.product will give you the result of the field "name" of the object product.template.

If you look at orm.py, line 2333 :
You will see that the ORM doesn't make any check on the existing fields in product.product before reading them in product.template.

I just added a check

- cols = intersect(self._inherit_fields.keys(), fields_to_read)
+ cols = [x for x in intersect(self._inherit_fields.keys(), fields_to_read) if x not in self._columns.keys()]

For information : "cols" is the variable which contains the fields that we have to read in the inherited object.

With this patch fields are only read in the inherited object if they are not found in the actual object.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Sébastien,

I disagree with you here. Why would you need to add 'name' column to product_product table?
Product already _inherits Templates and it has 'name' already.

Adding the same field on product will be ambiguous I guess.

Correct me if I am wrong.
Thanks.

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

Let's me explain.

When we use product_variant_multi, we build various product from the product template. As product.product inherit product_template the name of the product is same as the product template.

The idea is to have field "name" (a function field) on product_product which build a correct name with the product template name and the product variants. (product name = product template name + product variants)

I made a lots of test and there is nothing ambigous because is you want to read :
the product_template name you just have to do self.pool.get('product.template').read(....)
and the product_product name you just have to do self.pool.get('product.product').read(....).

Making this change on the orm will only impact people who are trying to overwrite field on inherit object. For the moment there is only the module product_variant_multi in development version.

I know that it's a little dangerous to create the field "name" in product.product and the reason is because the code is not enough clean, the proof I found this bug.

Please think twice before not fixing it, because without this we will never have a powerfull ORM.

What do you think?

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

Moreover only the read function have a bug. The write and create function work perfectly ;).

[Vinay Rana (OpenERP) (vra-openerp)]

We Let the Framework team decide.

Thanks.

[Fabien (Open ERP) (fp-tinyerp)]

patch applied in trunk r3142

[Olivier Dony (Odoo) (odo-openerp)]

Assigning to support team for backport to 5.0 if they think the risk is low enough and the bug is important enough..

[Anup(SerpentCS) (anup-serpent)]

Hello Sébastien,

      This is a new feature. It does not seem to be a blocking point, it does not break the system. IMHO it should be kept for the newer version(6.0).

Thanks.