checkValidId breaks on unicode ids

[Elizabeth Leddy]

In OFS, ObjectManager.py, if you send in a unicode id it raises bad a bad request, although it seems like one should still be able to send it in. The code looks like its missing an else statement:

def checkValidId(self, id, allow_dup=0):
    ...
    if not id or not isinstance(id, str):
        if isinstance(id, unicode):
            id = escape(id)
        raise BadRequest, ('Empty or invalid id specified', id)
    ...

Based on this it looks like the bad request error should only be thrown if the id is not unicode. Hard to say for sure though.
Running Zope 2.12 but it looks like its in the latest release as well.

[Hanno Schlichting (hannosch)]

Zope2 only supports ids in ascii, so the validator is correct. Adding support for Unicode ids is a long requested feature, which nobody had time to implement yet.

[Andreas Jung (ajung)]

Isn't there a huge Dieter patch floating around somewhere in the tracker?

[Hanno Schlichting (hannosch)]

There's https://bugs.launchpad.net/zope2/+bug/374724 which has some code and a really minor number of tests. With a change like this, there's lots of places where things will go wrong. So the provided patch is not more than a basic starting ground. The patch is even marked as "tests failing".

[Colin Watson (cjwatson)]

The zope2 project on Launchpad has been archived at the request of the Zope developers (see https://answers.launchpad.net/launchpad/+question/683589 and https://answers.launchpad.net/launchpad/+question/685285). If this bug is still relevant, please refile it at https://github.com/zopefoundation/zope2.