In swift.proxy.Controller, logic in account_info and container_info is problematic
Bug #671644 reported by
Greg Lange
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Object Storage (swift) |
Fix Released
|
Undecided
|
Greg Lange |
Bug Description
In both methods, result_code is not set properly.
If all the nodes return a 404, the response code should be a 404 instead of a -1.
Also, in account_info(), the logic for returning (partition, nodes) versus (None, None) is different when the response code is retrieved from memcache instead of determined by making requests of the nodes.
That logic should be, if the result_code is 200, return (partition, nodes) and if not return (None, None) in both places.
Related branches
lp:~greglange/swift/lp671644
- gholt (community): Approve
-
Diff: 124 lines (+71/-5)2 files modifiedswift/proxy/server.py (+10/-4)
test/unit/proxy/test_server.py (+61/-1)
Changed in swift: | |
assignee: | nobody → Greg Lange (greglange) |
Changed in swift: | |
status: | New → Fix Committed |
Changed in swift: | |
milestone: | none → 1.2.0 |
Changed in swift: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.