Launchpad itself

+check-links triggering an OOPS

Bug #671390 reported by Diogo Matsubara
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Ian Booth
Launchpad itself 10.11 "Tenacious Turkey"

Bug Description

As seen in OOPS-1769F1682 the LinkCheckerAPI is triggering a TypeError: expected string or buffer

Other examples: OOPS-1769A565, OOPS-1769M38

Related branches

lp:~wallyworld/launchpad/link-checker-oops
Tim Penhey (community): Approve
Revision history for this message
Gary Poster (gary) wrote :

I don't know the use of +check-links and I see that Ian worked on it. If this is a Foundations thing after all, please feel free kick it back, but then give us an idea of how it us used and any insights Ian might have.

Thanks

Gary

affects: launchpad-foundations → launchpad-code
Ian Booth (wallyworld)
Changed in launchpad-code:
assignee: nobody → Ian Booth (wallyworld)
Revision history for this message
Ian Booth (wallyworld) wrote :

The +check-links url is only supposed to be invoked from some javascript within an onload page event (where the necessary validation is done and the call is only made if there is link data to process). URL hacking or I think in this case direct navigation via a bot caused the error. I'll add some extra checking at the back end.

Ian Booth (wallyworld)
Changed in launchpad-code:
importance: Undecided → Medium
status: New → Confirmed
status: Confirmed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11913 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11913>.

Changed in launchpad-code:
milestone: none → 10.11
tags: added: qa-needstesting
Changed in launchpad-code:
status: In Progress → Fix Committed
Revision history for this message
Robert Collins (lifeless) wrote :

test url works on qastaging

tags: added: qa-ok
removed: qa-needstesting
Robert Collins (lifeless)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.