MIDI only saves the first output mappings with a given config key

[William Good]

I'm working with a controller with 5 leds that make up a VU meter (three greens, a yellow and a red). The following XML gives me a nice VU meter from mixxx:

      <output>
        <group>[Channel1]</group>
        <key>VuMeter</key>
        <status>0x90</status>
        <midino>0x29</midino>
        <on>0x7f</on>
        <minimum>0.2</minimum>
      </output>
      <output>
        <group>[Channel1]</group>
        <key>VuMeter</key>
        <status>0x90</status>
        <midino>0x2a</midino>
        <on>0x7f</on>
        <minimum>0.4</minimum>
      </output>
      <output>
        <group>[Channel1]</group>
        <key>VuMeter</key>
        <status>0x90</status>
        <midino>0x2b</midino>
        <on>0x7f</on>
        <minimum>0.6</minimum>
      </output>
      <output>
        <group>[Channel1]</group>
        <key>VuMeter</key>
        <status>0x90</status>
        <midino>0x2c</midino>
        <on>0x7f</on>
        <minimum>0.8</minimum>
      </output>
      <output>
        <group>[Channel1]</group>
        <key>VuMeter</key>
        <status>0x90</status>
        <midino>0x2d</midino>
        <on>0x7f</on>
        <minimum>1.0</minimum>
      </output>

However, after I select the preset containing that XML and quit mixxx, the midi file for the device in ~/.mixxx/midi only contains:

            <output>
                <group>[Channel1]</group>
                <key>VuMeter</key>
                <options>
                    <normal/>
                </options>
                <minimum>0.2</minimum>
                <maximum>1</maximum>
                <status>0x90</status>
                <midino>0x2d</midino>
                <on>0x7f</on>
                <off>0x0</off>
            </output>

so only the 0x902d7f message gets sent, and I only get one VU LED. Since the VU LEDs work fine after I first import the preset, I assume this bug lies in the routines used to save the mapping settings. All my other output mappings are fine, although the VU meter mappings are the only ones to have multiple <output>'s sharing the same group and key.

[William Good (bkgood)]

Fixed in 1.8 r2666

[William Good (bkgood)]

Fixed in trunk r2547

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5628