add affiliates filter for people tab (for non-osi)

[Jim B. Glenn]

before the update to people tab, non-osi customers had tabs for staff, affiliates, and all karl.

Tres wrote a groups based filter which is currently being used for the staff tab.
All karl works.

But we need a filter for affiliates. The "groups based filters" is not useable currently since KARL affiliates do not have a group of Karl Affiliates (except on OSI).

The way we did this before the people tab updates, was to do a query for not = group.KarlStaff

[Paul Everitt (paul-agendaless)]

Tres sent a note saying he was working on it:

- - I couldn't get to any old database which would have allowed me to
 look directly at the old affiliates reports. I didn't want to mess
 with the config files to try to work around that problem, either.

- - I just finished checking, and there is indeed no way the report could
 have been finding "not KarlStaff" people via a non-postprocessed
 catalog query: the indexes we are using don't support "not" queries,
 period.

- - I have an uncommitted checkin which gets members added via accepted
 invitations to get the 'groups.KarlAffiliate' group added. I checked
 the other points at which users get added: none of them need
 updating.

All that remains is an evolve step, I think. BTW, is there a Launchpad
issue for the feature?

[Paul Everitt (paul-agendaless)]

Jim sent over some Apache log files. In a 2 day period, Oxfam clicked on /people/affiliates 147 times. I think that's enough to answer the question of whether it was used.

[Tres Seaver (tseaver)]

Jim reports that the old implementation was configured as::

   <report id="affiliates" title="Affiliates">
       <query>{'is_staff': False}</query>
       <columns ids="name organization location email"/>
    </report>

which is much easier to emulate than a "not" query.

[Tres Seaver (tseaver)]

I have added a new 'is_staff' report filter object, and made it
addable in a report. Setting the 'include_staff' value to false causes
the report to include only affiliates.

[Paul Everitt (paul-agendaless)]

Sending to JimP to chat with JimB about who gets this into production for Oxfam.

[JimPGlenn (jpglenn09)]

fixed