Launchpad itself

IHasTranslationImports exported incorrectly

Bug #668194 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Jeroen T. Vermeulen
Launchpad itself 10.11 "Tenacious Turkey"

Bug Description

The IHasTranslationImports classes implement IHasTranslationImports, which is exported on the API. Unfortunately doing it this way turns out to create a separate API class (unreachable as far as I can see) called object_with_translation_imports instead of adding the interface's methods to person, distroseries etc. The test infrastructure was hiding this fact by making it look as if things worked the way we wanted (bug 668190) once we started exporting a method on this interface (bug 664327).

Instead of making Person, Product etc. implement IHasTranslationImports we need to derive IPerson, IProduct etc. from IHasTranslationImports. Doing that will upset our module dependencies a bit, so it looks like there will be circular imports.

Related branches

lp:~jtv/launchpad/bug-668194-split-interfaces
Abel Deuring (community): Approve (code)
Diff: 989 lines (+199/-169)
42 files modified
lib/canonical/launchpad/interfaces/_schema_circular_imports.py (+3/-1)
lib/lp/code/model/tests/test_branchjob.py (+1/-1)
lib/lp/registry/configure.zcml (+6/-6)
lib/lp/registry/doc/distribution.txt (+1/-1)
lib/lp/registry/doc/distroseries.txt (+1/-1)
lib/lp/registry/doc/person.txt (+1/-1)
lib/lp/registry/doc/product.txt (+1/-1)
lib/lp/registry/doc/productseries.txt (+1/-1)
lib/lp/registry/doc/sourcepackage.txt (+1/-1)
lib/lp/testing/factory.py (+1/-3)
lib/lp/translations/browser/hastranslationimports.py (+4/-2)
lib/lp/translations/browser/translationimportqueue.py (+1/-1)
lib/lp/translations/doc/poexport-language-pack.txt (+2/-1)
lib/lp/translations/doc/poimport-pofile-not-exported-from-rosetta.txt (+2/-1)
lib/lp/translations/doc/poimport-pofile-old-po-imported.txt (+1/-2)
lib/lp/translations/doc/poimport-pofile-syntax-error.txt (+1/-2)
lib/lp/translations/doc/poimport-potemplate-syntax-error.txt (+1/-2)
lib/lp/translations/doc/poimport.txt (+2/-1)
lib/lp/translations/doc/rosetta-karma.txt (+2/-1)
lib/lp/translations/doc/rosetta-poimport-script.txt (+2/-1)
lib/lp/translations/doc/translationimportqueue.txt (+2/-1)
lib/lp/translations/enums.py (+67/-0)
lib/lp/translations/interfaces/hastranslationimports.py (+64/-0)
lib/lp/translations/interfaces/translationimportqueue.py (+4/-95)
lib/lp/translations/interfaces/webservice.py (+3/-1)
lib/lp/translations/model/approver.py (+1/-3)
lib/lp/translations/model/pofile.py (+5/-10)
lib/lp/translations/model/potemplate.py (+1/-3)
lib/lp/translations/model/translationimportqueue.py (+4/-2)
lib/lp/translations/scripts/po_import.py (+1/-1)
lib/lp/translations/scripts/tests/test_translations_import.py (+1/-3)
lib/lp/translations/tests/test_autoapproval.py (+1/-1)
lib/lp/translations/tests/test_rosetta_branches_script.py (+1/-1)
lib/lp/translations/tests/test_translationbranchapprover.py (+1/-1)
lib/lp/translations/tests/test_translationbuildapprover.py (+1/-1)
lib/lp/translations/tests/test_translationimportqueue.py (+1/-1)
lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py (+1/-3)
lib/lp/translations/utilities/tests/helpers.py (+1/-1)
lib/lp/translations/utilities/tests/test_xpi_import.py (+1/-3)
lib/lp/translations/utilities/tests/test_xpi_po_exporter.py (+1/-1)
lib/lp/translations/utilities/tests/test_xpi_search.py (+1/-3)
lib/lp/translations/utilities/translation_import.py (+1/-3)
lp:~jtv/launchpad/bug-668194-fix-api
Abel Deuring (community): Approve (code)
Diff: 562 lines (+94/-78)
22 files modified
lib/lp/registry/configure.zcml (+0/-12)
lib/lp/registry/interfaces/distribution.py (+5/-2)
lib/lp/registry/interfaces/distroseries.py (+5/-1)
lib/lp/registry/interfaces/person.py (+4/-1)
lib/lp/registry/interfaces/product.py (+7/-3)
lib/lp/registry/interfaces/productseries.py (+4/-1)
lib/lp/registry/interfaces/sourcepackage.py (+4/-1)
lib/lp/registry/model/distribution.py (+1/-1)
lib/lp/registry/model/distroseries.py (+3/-3)
lib/lp/registry/model/person.py (+1/-1)
lib/lp/registry/model/product.py (+3/-3)
lib/lp/registry/model/productseries.py (+3/-3)
lib/lp/registry/model/sourcepackage.py (+3/-3)
lib/lp/translations/browser/hastranslationimports.py (+3/-2)
lib/lp/translations/interfaces/hastranslationimports.py (+1/-1)
lib/lp/translations/interfaces/webservice.py (+0/-2)
lib/lp/translations/model/approver.py (+4/-4)
lib/lp/translations/model/hastranslationimports.py (+36/-0)
lib/lp/translations/model/pofile.py (+3/-3)
lib/lp/translations/model/translationimportqueue.py (+0/-26)
lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py (+4/-4)
lib/lp/translations/utilities/tests/test_xpi_search.py (+0/-1)
Jeroen T. Vermeulen (jtv)
summary: - IHasTranslationImports.getTranslationImportQueueEntries exported wrongly
+ IHasTranslationImports exported incorrectly
Jeroen T. Vermeulen (jtv)
Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11828 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11828>.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r11829 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11829>.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r11828 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11828>.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r11829 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11829>.

Jeroen T. Vermeulen (jtv)
tags: added: qa-ok
removed: qa-needstesting
Robert Collins (lifeless)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.