save and close crash adding product in point of sale

[Cristian Salamea]

Hello, i am testing POS module, i added the pos_add_product wizard as button in POS Orden view, then follow this steps:

1 Click on Add Product
2 Select product (change qty)
3 Click on 'Save & Close' button

I get this error: http://openerp.pastebin.com/T1xZSMgw
This button call close_action, i really dont understand what code wants to do there, 'Save $ Close' tells the user add the pos line what you select and close this wizard, maybe launch the payment wizard, but never is added the pos line.
Its necessary use add_product method from pos.order, i added a simple patch but this dont update the view with new product added.

Regards,

[Ravindra Mekhiya(OpenERP) (rme-openerp)]

Hello Cristian,

Would you please apply the attached patch and notify us.

Hope this will help you.

Thanks for pointing out.

[Cristian Salamea (ovnicraft)]

Hello, here i'll patch it (and maybe other bugs). https://code.edge.launchpad.net/~ovnicraft/openobject-addons/dev-point_of_sale

Regards,

[Rucha (Open ERP) (rpa-openerp)]

Hello Cristian,
I have followed the steps in latest trunk-addons, but I am not able to reproduce,
"Save & close" button in Add products wizard prompt for "Make Payement", but when we click on cancel, it successfully adds the product in pos lines,
I have also checked the error in given link: http://openerp.pastebin.com/T1xZSMgw
Having a look on it, it seems that you have an error in "Return Products" not in "Add Products",
[I paste here one line from above link: File "/home/ovnicraft/repos/openerp-commiter/addons_trunk/point_of_sale/wizard/pos_return.py", line 344, in close_action],=> this is from "Return Products".
Can you make it clear?

Thanks

[Cristian Salamea (ovnicraft)]

@rpa i added the button from my pos_module i dot this with a view inherited: http://openerp.pastebin.com/Ari5nEDT and error is reproduced in Save & Close button.

Regards,

[Rucha (Open ERP) (rpa-openerp)]

ok, I confirm this

[Priyesh (OpenERP) (pso-openerp)]

Hello,

It has been fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/pso-dev-addons3.

This branch will be merged soon with Addons3.

Thank you for your contribution.

Thanks RME, for your patch.

[Cristian Salamea (ovnicraft)]

Thanks for this guys, if you can check my repo has some changes for POS.

regards,

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

Hello Cristian Salamea,

Yes we can check, can you send merge proposal to Addons3 branch ?

thanks
mra

[Cristian Salamea (ovnicraft)]

@mra i did it, waiting for your feedback

Regards,

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

hello Cristian,

yes we will check it soon.

thanks,
mra