[win32] desktopcover: gdk_property_get not implemented

Bug #666394 reported by Johannes Sasongko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Low
Mathias Brodala

Bug Description

Enabling the Desktop Cover plugin in Windows produces a warning:

  C:\exaile\xlgui\guiutil.py:109: GtkWarning: gdk_property_get: Not implemented
    return rootwindow.property_get(workarea)[2][2:4] # W,H

and sometimes followed by an error:

  Traceback (most recent call last):
    File "C:\exaile\xl\plugins.py", line 124, in enable_plugin
      plugin.enable(self.exaile)
    File "C:\exaile\plugins\desktopcover\__init__.py", line 63, in enable
      DESKTOPCOVER = DesktopCover()
    File "C:\exaile\plugins\desktopcover\__init__.py", line 118, in __init__
      self.update_position()
    File "C:\exaile\plugins\desktopcover\__init__.py", line 181, in update_position
      workarea_width, workare_height = get_workarea_size()
    File "C:\exaile\xlgui\guiutil.py", line 109, in get_workarea_size
      return rootwindow.property_get(workarea)[2][2:4] # W,H
  TypeError: 'NoneType' object is unsubscriptable

(Note: I've modified some files, so line numbers may not be accurate).

gdk.Window.property_get always returns None and prints out the warning.

Related branches

description: updated
description: updated
Changed in exaile:
milestone: 0.3.3.0 → 0.3.3.1
Revision history for this message
Mathias Brodala (mathbr) wrote :

One possible solution would be falling back to gtk.gdk.Screen. Can you see which part exactly fails in xlgui.guiutil.get_workarea_dimensions()?

Revision history for this message
Johannes Sasongko (sjohannes) wrote :

Well, gdk_property_get does nothing in Win32 [1]. The PyGTK version just returns None.

[1] http://git.gnome.org/browse/gtk+/tree/gdk/win32/gdkproperty-win32.c#n116

Changed in exaile:
assignee: Johannes Sasongko (sjohannes) → nobody
Revision history for this message
Mathias Brodala (mathbr) wrote :

Should be fixed with r4201. Please let me know if it is not.

Changed in exaile:
assignee: nobody → Mathias Brodala (mathbr)
status: Confirmed → Fix Committed
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.