[5.0] Incorrect reuse of same m2m table by 2 osv objects in document module prevents creating more than a few files

[nima]

hi,
this is the full cause of problem.i go to the document management module::search a file::New.
in the new section when i choose a file and attach it without any further changes it operates fine .but when i go to security tab and add some groups i get the following integrity error:

Integrity Error

insert or update on table "document_directory_group_rel" violates foreign key constraint "document_directory_group_rel_item_id_fkey"
DETAIL: Key (item_id)=(228) is not present in table "document_directory".

what is it??

thank you

[xrg (xrg)]

On Monday 25 October 2010, you wrote:
> Public bug reported:
>
> hi,
> this is the full cause of problem.i go to the document management
> module::search a file::New. in the new section when i choose a file and
> attach it without any further changes it operates fine .but when i go to
> security tab and add some groups i get the following integrity error:
>

What version of OpenERP are you using?

Did you refresh the list on the OpenERP client interface, after operating
through FTP? You know, FTP is a parallel client, so its opeations need to be
synchronised..

[Olivier Dony (Odoo) (odo-openerp)]

re-filing under addons, document_ftp is a separate module, not part of the core

[Olivier Dony (Odoo) (odo-openerp)]

Hello,
We can't reproduce on latest trunk, and the scenario you are describing does not seem to indicate that you are using the latest version.
Could you try again with the latest 6.0 version (RC1)?

If you manage to reproduce, please mention the exact version and steps to reproduce it (for example it's not clear in your description when you actually used the FTP protocol, or if you only used an OpenERP client)

Thank you!

[nima (0.5a)]

i am using openerp 5.0.14 .under client software i use Document Management.and when i go to search a file in that module i press from above the form New.in this section i browse my file and in permission section i choose the groups that i want to give access to connect to this file .if i press save it will bring on the error.but when i don't specify permissions it will save ok.it happens if i even change the existing file permission list.
thank you

[nima (0.5a)]

anybody have any idea about this problem?does it occur to u too?

[nima (0.5a)]

ok,i deleted "document_directory_group_rel_item_id_fkey" manually in my database and everything is ok now.i certainly believe this is not a bug but a misuse of the database.so does anyone have any idea what that constraint was doing and why every thing is OK in a fresh database and not mine?

[LudoRA (tenshi20)]

Hi!

This bug affect me too. It's exactly the same way to reproduce it.

I'm using 5.0.15 version. It was working for few day, and now, it isn't.

[LudoRA (tenshi20)]

After code analyse, I can reproduce this bug with a 5.0.15 fresh install.

This portion of error message DETAIL: Key (item_id)=(228) is not present in table "document_directory" give us the information that 228 is not prensent in document_directory table. It's logic because this table list directories, not documents (that are in ir.attachment table).

So, when we increase the id of our documents, when we are over the most id of directory, the database refuse to be updated because of id of the document isn't in the list of directory.

It could have an ir_attachment_group_rel table to reference security rules for each document .

[LudoRA (tenshi20)]

Change the 586'th line :

        'group_ids': fields.many2many('res.groups', 'document_directory_group_rel', 'item_id', 'group_id', 'Groups'),
to
        'group_ids': fields.many2many('res.groups', 'ir_attachment_group_rel', 'item_id', 'group_id', 'Groups'),

It seems to work with a fresh install.
For an already exist install, I suppose that you have to reaffect group for each document you have already put on the server.

Do you think it's a good way to sove the problem?

[Olivier Dony (Odoo) (odo-openerp)]

@LudoRA: your analysis is totally correct, the name of the many-to-many relationship table of the document.directory class was reused incorrectly in the document_directory class!
Thanks to you and Nima for reporting and analyzing this issue.

I can confirm that 6.0 is unaffected, so this is only in the 5.0 series.

As a result, I am assigning to the maintenance team, so they can apply the fix.

[Olivier Dony (Odoo) (odo-openerp)]

@LudoRA: your patch would work, and here is a similar one in patch format, that should be readily applicable to any 5.0 installation. Note that you need to manually trigger an update of the document module after applying the patch.

[LudoRA (tenshi20)]

@Olivier Dony: OK. Can we consider this patch like an official patch that is compatible with futures versions of 5.0 series? Or must we wait for a validation?

[Jay Vora (Serpent Consulting Services) (jayvora)]

Thanks everyone for the participation.
It has been fixed in 5.0 by revision 2899 <email address hidden>.