Creating invoices and grouping multiplies services

[Milan Tribuson]

Running wizard "Create invoice" with "Group" option checked from outgoing products for 2 or more picking lists that are created from a same sale order, invoice will be created with multiplied service products (ie. if there is a sale order with 1 stockable product and 1 service and 2 picking lists -> invoice will have 1 stockable products and 2 services)...
When I create invoices one picking at the time, all service products form sale order will be added to the first invoice (created from the first picking) and other invoices created from other picking lists which were created from the sale order will have no service products on them (which is more or less ok).
So, this is a bug when we create 1 invoice with group option checked for all picking lists created from the same sale order .

I'm using version 5.0.14

[Fabien (Open ERP) (fp-tinyerp)]

to be improved in trunk, the Group by Partner button does not work, it does not group by partner.
Also, for useability issues, on the "Outgoing Delivery" order, put the "Create Invoice button" visible only when the picking is done, not when it's confirmed or assigned.

[Milan Tribuson (milan-infokom)]

It milestone is 6.0-rc2 it will not be fixed in version 5?

[Rohan Nayani(Open ERP) (ron-tinyerp)]

Hello Mile Infokom,

Thanks for reporting,
It has been fixed in lp:~openerp-dev/openobject-addons/ron-dev-addons2
Revision ID: <email address hidden>
Revision num: 5048.
It will be available in trunk soon,

[Milan Tribuson (milan-infokom)]

Hi ron!

I was checking your changes in stock/wizard/stock_invoice_onshipping.py and is there a reason to have an if-then block like you wrote from lines 128 to 141 because the statements are the same in "if" and "else" block? And is there a reason to create invoice_obj and invoice_line_obj when you don't use them? (or maybe you use them somewehere else in code?)