Confirm messages in buttons are not exported in .pot to translate (v 5.0 and 6.0)

[Jordi Esteve (www.zikzakmedia.com)]

Confirm messages in buttons are not exported in .pot files, so they can not be translated. It affects v 5.0 and 6.0.

They are used in account_voucher and stock modules, for example:

<button name="cancel_voucher" string="Cancel" type="object" states="posted" icon="terp-stock_effects-object-colorize" confirm="Are you sure to confirm this record ?"/>

[Margarita Manterola (marga)]

I experienced this bug and since I was in serious need of translation, I went ahead and patched my server. I'm attaching the diff. I'd appreciate if this could be applied to both v5 and v6.

Thanks!

[Olivier Dony (Odoo) (odo-openerp)]

Hello Jordi and Manterola,

Thanks for the patch!
We will definitely fix it on trunk for 6.0, and we'll see with the "stable" team if they think this issue is important enough and low-risk enough to apply on 5.0

[Olivier Dony (Odoo) (odo-openerp)]

Thank you for the patch, Margarita!
It has been applied in trunk with revision 3055 <email address hidden>

For 5.0, I will ask the stable team of they would consider applying the same fix or if it doesn't qualify for inclusion in a stable release.

[Olivier Dony (Odoo) (odo-openerp)]

Jay, I'm re-targetting to 5.0 and assigning to you, in case you consider this fix worth including in a 5.0. I think it's quite low-risk, but it's far from blocking indeed.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Margarita Manterola ,

Thanks for the patch.
It has been fixed by revision 2167 <email address hidden> authored to you.