Fix parameter order for Tree.add
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Dulwich |
Fix Released
|
Low
|
Jelmer Vernooij |
Bug Description
affects dulwich
status triaged
importance low
On Tue, 2010-10-19 at 10:07 -0700, David Borowitz wrote:
> On Sat, Oct 16, 2010 at 14:59, Jelmer Vernooij <email address hidden>
> wrote:
> On Fri, 2010-10-08 at 12:51 -0700, David Borowitz wrote:
> > Another place with a completely different order:
> Tree.add(mode, name,
> > sha). I don't suppose that's one we can safely change, is
> it?
>
> I guess we could check the types of mode and name and reverse
> them (and
> print a DeprecationWarning) if they're wrong.
>
> It's not entirely nice but I think the cleanest way of fixing
> it.
>
>
> Yeah. I don't have a sense of whether this is a thing other Python
> projects do...
>
>
> I'm happy to make this change but it's not on my critical path at the
> moment.
Related branches
- VCS imports: Pending requested
-
Diff: 152 lines (+44/-12)7 files modifiedNEWS (+6/-0)
docs/tutorial/object-store.txt (+1/-1)
dulwich/index.py (+1/-1)
dulwich/objects.py (+8/-3)
dulwich/tests/test_fastexport.py (+1/-1)
dulwich/tests/test_objects.py (+21/-0)
dulwich/tests/test_patch.py (+6/-6)
Changed in dulwich: | |
status: | Triaged → In Progress |
assignee: | nobody → Jelmer Vernooij (jelmer) |
Changed in dulwich: | |
status: | In Progress → Fix Committed |
milestone: | none → 0.7.1 |
Changed in dulwich: | |
status: | Fix Committed → Fix Released |