Unportable test(1) construct

[Thomas Klausner]

As of version 0.11, bzr is using the unportable bash extension "==" for test(1) in contrib/fortune. This is not supported by most other shells or even test(1) from GNU coreutils. Please use "=" instead. I'll attach a patch (if I manage).

[Robert Collins (lifeless)]

On Mon, 2006-10-16 at 01:08 +0000, Thomas Klausner wrote:
> Public bug reported:
>
> As of version 0.11, bzr is using the unportable bash extension "==" for
> test(1) in contrib/fortune. This is not supported by most other shells
> or even test(1) from GNU coreutils. Please use "=" instead. I'll attach
> a patch (if I manage).

We dont use or install contrib/fortune. I think we should just remove
it, in favour of actual documentation.

-Rob

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Martin Pool (mbp)]

Hi,

Can you tell me more about how you encountered this? That plugin is just intended as an example.

[Thomas Klausner (tk-giga)]

On Mon, Oct 16, 2006 at 03:33:16AM -0000, Martin Pool wrote:
> Can you tell me more about how you encountered this? That plugin is
> just intended as an example.

It was found during a search for this type of problems.
If the code is not used, so much the better.
I think it should be fixed to not serve as a wrong
example, though :)

Cheers,
 Thomas

[John A Meinel (jameinel)]

I agree that we should just delete that file.
I would also be very much in favor of deprecating ExternalCommand, and then removing support for it entirely.