[6.0][sale][HIGH] Services sale order never finished

[Omar (Pexego)]

Hi,

I create sale order with one service line, when I confirm it, it executes action_ship_create() function, in this function, if product isn't service, it creates a picking, a move and then a procurement where it sets the created move, but if the product is service it only creates the procurement, without move. Then, in procurements, I confirm the procurement and it in the end calls to check_move_done() function, in this function it does:

return all(procurement.move_id.state == 'done' for procurement in self.browse(cr, uid, ids))

But, my service procurement hasn't move_id and it always returns False and it never finished the procurement therefore it never finished the sale order.

I think that, if procurement hasn't move, it should finish always. But, why does procurement exist for service products? or, why does procurement create without move_id?

[Azazahmed Saiyed (OpenERP) (saz-openerp)]

Hello Omar,

Basically the procurement of service type product leads to project task by executing the Compute Schedule wizard.For that you need to install project module with it.

Thanks.

[Omar (Pexego) (omar7r)]

Hi Saz,

You should install project_mrp for it you said, this module modifies procurement workflow and it finished the procurement when you closed the task created, but if you didn't install this module, procurement never finishes, because it hasn't task nor move therefore sale never finished.

[Azazahmed Saiyed (OpenERP) (saz-openerp)]

Hello Omar,

Thanks for your suggestion.Currently we are focusing on current OpenERP release and unfortunately the issue is not affecting it.So we will definitely take into account for future versions of OpenERP.

Thanks.

[Omar (Pexego) (omar7r)]

Hi Saz,

Ok, but I hope that this issue will be fixed, workflow should finish. In this case sale order won't finish. Openerp is forced to us to install project_mrp to finished services sale orders.

[Omar (Pexego) (omar7r)]

Hi Saz,

Reviewing your last message, I have to say you that this issue affects to 6.0 (title), therefore, you can't exclude it.

[Fabien (Open ERP) (fp-tinyerp)]

I confirm we have to fix this for 6.0-RC2. The workflow should finish even if you did not installed project_mrp.
(it's not automated, you have to launch the scheduler or install mrp_jit to schedule in real time)
So, be sure the workflow has a path to finish for services in MTO, without having installed project_mrp. (with launching the scheduler)

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Dear Kyle,

the shipping product is a "service", could you please check if the bug you see is that OpenERP bug:
https://bugs.launchpad.net/magentoerpconnect/+bug/512756 ?

A simple check is to reproduce your order with some shipping product you'll create manually (identical to the one created by magentoerpconnect) but without the connector installed.

The bug I'm mentioning is certainly annoying, fortunately OpenERP SA seems to be aware of that and they are likely to fix it soon, well hopefully.

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Hello, sorry, posted my previous post at the wrong place, I was actually suggesting a guy to investigate if one of the bugs reported against the Magento OpenERP connector was a duplicate of that addons bugs.
The probable duplicate is here actually https://bugs.launchpad.net/magentoerpconnect/+bug/512756
I just updated the thread for that other bug too.

[Kirti Savalia(OpenERP) (ksa-openerp)]

Hello Omar,

 it has been fixed in branch lp:~openerp-dev/openobject-addons/ksa-addons2
Revision NO - 3845
Revision ID: <email address hidden>

Thanks.