crashes when saving page as empty

Bug #661973 reported by Jelmer Vernooij
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Wikkid Wiki
Fix Released
High
Jelmer Vernooij

Bug Description

When removing all data from an existing page, wikkid crashes while saving - giving only a page with a single error "A server error occurred. Please contact the administrator."

Relevant traceback:

Traceback (most recent call last):
  File "/usr/lib/python2.6/wsgiref/handlers.py", line 93, in run
    self.result = application(self.environ, self.start_response)
  File "/usr/lib/python2.6/dist-packages/wikkid/user/bzr.py", line 40, in __call__
    resp = req.get_response(self.app)
  File "/usr/lib/pymodules/python2.6/webob/request.py", line 919, in get_response
    application, catch_exc_info=False)
  File "/usr/lib/pymodules/python2.6/webob/request.py", line 887, in call_application
    app_iter = application(self.environ, start_response)
  File "/usr/lib/python2.6/dist-packages/wikkid/app.py", line 77, in __call__
    response = view.render(self.skin)
  File "/usr/lib/python2.6/dist-packages/wikkid/view/base.py", line 121, in render
    return self._render(skin)
  File "/usr/lib/python2.6/dist-packages/wikkid/view/textfile.py", line 63, in _render
    content, self.user.committer_id, rev_id, message)
  File "/usr/lib/python2.6/dist-packages/wikkid/model/file.py", line 24, in put_bytes
    self.write_filename, bytes, committer, rev_id, commit_msg)
  File "/usr/lib/python2.6/dist-packages/wikkid/filestore/bzr.py", line 79, in update_file
    commit_message)
  File "/usr/lib/python2.6/dist-packages/wikkid/filestore/bzr.py", line 145, in _update_file
    new_ending = get_line_ending(new_lines)
  File "/usr/lib/python2.6/dist-packages/wikkid/filestore/bzr.py", line 32, in get_line_ending
    first = lines[0]
IndexError: list index out of range

Related branches

Tim Penhey (thumper)
Changed in wikkid:
status: New → In Progress
importance: Undecided → High
milestone: none → 0.2
assignee: nobody → Jelmer Vernooij (jelmer)
Tim Penhey (thumper)
Changed in wikkid:
status: In Progress → Fix Committed
Jelmer Vernooij (jelmer)
tags: added: verified
Jelmer Vernooij (jelmer)
tags: removed: verified
xaav (xaav)
Changed in wikkid:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.