Quiet parametr for creating "manual" MTA is noisy

[Bartosz Szatkowski]

[ steps ]
  call Mailman.MTA.Manual.create(..., quiet=True)

eg
         if mm_cfg.MTA:
             modname = 'Mailman.MTA.' + mm_cfg.MTA
             __import__(modname)
             sys.modules[modname].create(mlist, quiet=True)

[ result ]
  output:
 test-devel: "|/var/lib/mailman/mail/mailman post test-devel"
test-devel-admin: "|/var/lib/mailman/mail/mailman admin test-devel"
test-devel-bounces: "|/var/lib/mailman/mail/mailman bounces test-devel"
test-devel-confirm: "|/var/lib/mailman/mail/mailman confirm test-devel"
test-devel-join: "|/var/lib/mailman/mail/mailman join test-devel"
test-devel-leave: "|/var/lib/mailman/mail/mailman leave test-devel"
test-devel-owner: "|/var/lib/mailman/mail/mailman owner test-devel"
test-devel-request: "|/var/lib/mailman/mail/mailman request test-devel"
test-devel-subscribe: "|/var/lib/mailman/mail/mailman subscribe test-devel"
test-devel-unsubscribe: "|/var/lib/mailman/mail/mailman unsubscribe test-devel"

[ expected result]

  totaly quiet "output"

[ fix ]
Sorry Iam kind of busy right now - cant make the patch
Line 82-87 in Mailman/MTA/Manual.py should be indented one more level

 82 print _("""\
 83 ## %(listname)s mailing list""")
 84 outfp = sys.stdout
 85 # Common path
 86 for k, v in makealiases(listname):
 87 print >> outfp, k + ':', ((fieldsz - len(k)) * ' '), v

[Mark Sapiro (msapiro)]

The current behavior is what is intended.

The only thing in Mailman which calls MTA.Manual.create(..., quiet=True) is "bin/genaliases --quiet" when MTA="Manual". The documentation for the genaliases --quiet option is

. Some MTA output can include more verbose help text. Use this to tone
. down the verbosity.

Further, when MTA = "Manual" the only thing genaliases does is print aliases. Thus, if calling MTA.Manual.create(..., quiet=True) produced no output, "bin/genaliases --quiet" would do nothing so why would one want to run it at all.