rebooting buildbot slave environment doesn't remove test librarian pid

Bug #661009 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Stuart Bishop

Bug Description

We recently had a stale librarian pid on the db-devel working (Oct 15th).

Apparently the machine was rebooted to add memory at about the same time so we're thinking its related.

Now, it may be that we need to translate SIGTERM into a SystemExit exception (because we're not using atexit as much - and we do have a SIGTERM handler installed (outside the test suite, kindof)).

I've asked Tom Haddon to clear the pid when the machine is rebooted, while we figure out why the machine reboot didn't catch this.

Obviously non-clean shutdowns could cause this too, OTOH we're heading towards proper isolation with random dirs, so I don't think we need to panic about every possible cause - just the obvious ones (and if we think they could affect production shutdowns etc, we should address them in an appropriate fashion).

Related branches

Revision history for this message
Robert Collins (lifeless) wrote :

We do have a SIGTERM handler in bin/test which (I've checked) will cause stack unwind to happen. So it may be a twistd bug, or SIGTERM wasn't sent.

Gary Poster (gary)
Changed in launchpad-foundations:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Robert Collins (lifeless) wrote :

My librarian branch will fix by using dynamic pids.

Changed in launchpad-foundations:
assignee: nobody → Robert Collins (lifeless)
status: Triaged → In Progress
summary: - rebooting buildbot slave environment doesn't remove test li brarian pid
+ rebooting buildbot slave environment doesn't remove test librarian pid
Changed in launchpad:
assignee: Robert Collins (lifeless) → Stuart Bishop (stub)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
Changed in launchpad:
milestone: none → 11.02
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
tags: added: qa-untestable
removed: qa-needstesting
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.