python-qt4 4.7.4 breaks git-cola
Bug #660363 reported by
daveinthesky
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
git-cola (Ubuntu) |
Triaged
|
Medium
|
Unassigned | ||
Bug Description
Binary package hint: python-qt4
Ubuntu 10.10 64-bit
python-qt4: Installed: 4.7.4-0ubuntu1
I need help triaging git-cola bug #62 to the PyQt4 developer.
http://
The code in question has worked fine from 4.3.0 to 4.7.3.
I'm concerned about 4.7.4 because of this and other bugs.
For example, issue #65 also seems isolated to this version of PyQt4.
http://
In all previous versions, the "Actions" dock widget contains buttons. In 4.7.4, the buttons are missing.
The actions dock widget is created in cola/views/
It utilizes a custom widget defined in cola/qt.py
Changed in python-qt4 (Ubuntu): | |
assignee: | nobody → Mackenzie Morgan (maco.m) |
Changed in git-cola (Ubuntu): | |
importance: | Undecided → Medium |
Changed in git-cola (Ubuntu): | |
assignee: | Mackenzie Morgan (maco.m) → nobody |
To post a comment you must log in.
I found the issue. PyQt4 <= 4.7.3 would report bool(QLayout()) == True while the new 4.7.4 release treats bool(QLayout()) as False.
This is a behavior change, but it's better for the code to be explicit and check "if foo is None:" instead of checking "if foo:", so it's likely that it was intentional.
In any case, git-cola 1.4.2.5 works around this and is no longer affected.