Midi Learning Wizard not working with Mac OSX anymore

Bug #659903 reported by jus
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
RJ Skerry-Ryan

Bug Description

Bug from the forum: http://mixxx.org/forums/viewtopic.php?f=3&t=1704
Can confirm with fresh Mixxx 1.8.0 final installation / MacOS 10.6 / 10.5

Mapping controllers with the Midi Learning Wizard does not work.
This is a regression from 1.8.0 beta2

mixxx --mididebug shows that Mixxx actually receives messages from the controller, but the Wizard shows nothing.

Error message in the terminal:
Warning: [PM 0. VCI 300 DJ Controller]: QObject::connect: Cannot queue arguments of type 'MidiMessage'
(Make sure 'MidiMessage' is registered using qRegisterMetaType().)

Revision history for this message
jus (jus) wrote :
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Can you try this workaround: Add or remove any line from the MIDI mapping table before trying to run the MIDI learning wizard.

qRegsiterMetaType<MidiMessage>("MidiMessage") is called in only one of hte MidiMessage constructors, but that constructor should be triggered by adding or removing a line from the MIDI mapping table.

Thanks,
RJ

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hmm, after more review I don't actually think that will work.

Revision history for this message
jus (jus) wrote :

Yes, too bad. That does not work .

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Jus, I just added a fix in the 1.8 branch. Could you test that please?

Changed in mixxx:
status: New → Confirmed
milestone: none → 1.8.1
Revision history for this message
jus (jus) wrote :

Thanks , Midi Wizard working again :-)

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Great, this fix will be in 1.8.1

Changed in mixxx:
status: Confirmed → Fix Committed
assignee: nobody → RJ Ryan (rryan)
importance: Undecided → Medium
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
jus (jus) wrote :

Bug not completely fixed. A user reported in the forum that the Wizard does not work in Mixxx 1.8.1 MacOSX bundle http://mixxx.org/forums/viewtopic.php?f=3&t=1793 . Can confirm , same error message as in #1.

When building mixxx r2656 (release) from source and running from build directory (osx32_build) the MidiWizard is working. This was also what i tested b4 my comment #6 .
But if you run "scons bundle" and make the Mixxx.app application bundle the wizard does not work anymore when running mixxx from within the bundle or start normally via click on Mixxx.app.
I notice the "mixxx" binary in "Mixxx.app/Contents/MacOS/" is not the same (different size/md5) as in osx32_build.

Dunno if this is the way "scons bundle" is supposed to work...

Revision history for this message
oui3dave (bcamedialabs) wrote :
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hmm, so in the latest 1.8.1 package (make sure you re-download it. Albert silently re-uploaded a new one) MIDI learn is broken?

Changed in mixxx:
status: Fix Released → In Progress
status: In Progress → Triaged
Revision history for this message
jus (jus) wrote :

Re-downloadeded 1.8.1 OSX from mixxx.org today and still got the error.
Mapping controls with MIDI wizard does not work , below is terminal output for the crossfader as example.

mixxx --mididebug

Debug: [Main]: MidiMapping: Learning started!
Debug: [PM 0. VCI 300 DJ Controller]: "MIDI ch 1: opcode: 90, ctrl: 25, val: 7F"
Warning: [PM 0. VCI 300 DJ Controller]: QObject::connect: Cannot queue arguments of type 'MidiMessage'
(Make sure 'MidiMessage' is registered using qRegisterMetaType().)

Revision history for this message
jus (jus) wrote :

With latest trunk http://bazaar.launchpad.net/~mixxxdevelopers/mixxx/trunk/revision/2581 the wizard is working again - However :-)
Tested with OSX 10.6.5 and QT 4.7.1 , both from build directory and Mixxx.app bundle ( see comment #8)
Somebody can confirm?

Revision history for this message
William Good (bkgood) wrote :

I'm marking this fix committed for the time being -- if this is broken (or ever broken again) for anyone, feel free to take it back to confirmed or triaged.

jus, would you mind making sure this works in lp:mixxx/1.9 ? Thanks!

Changed in mixxx:
milestone: 1.8.1 → 1.9.0
status: Triaged → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5560

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.