errors during mpd connection lead to endless loop

[Christian Weiske]

my mpd is password protected, and I did not have the MPD_PASSWORD environment variable set.
mpd-sound-menu starts up and shows in the menu. Now I press the "play" button in the sound menu and on the console I get:
> Disconnected from mpd!!
every second now I get that output, forever until I kill the process. The tool should show the error via i.e notification (or on the console if the starting process is a user-controlled shell) and end itself if a authentication connection error occurs.

[Vsevolod Velichko (torkvemada)]

Added 4-seconds pause between connections. 20 unsuccessful connections in a row will cause mpd-sound-menu shut down.

[Christian Weiske (cweiske)]

I can confirm the 4 seconds delay, but not the shutdown after 20 unsuccessful connections.

Maybe shutting down mpd-sound-menu isn't such a good solution; because a remote mpd server could just be in another network when I'm traveling with my laptop. slowy updating the time between connection attempts up to 30 seconds should be fine. That is, at the beginning, try it every second, after some fails go to 5 seconds, then 15, then 30. keep it at that rate then.

I think that synergy2 [1] does it the same way when the server is not reachable.

[1] http://synergy2.sf.net/