DC++ Allowing \n char in Titlebar/topic

[iceman50]

As of DC++ 0.777 Rev. 2258, DC++ is allowing \n (newline) characters to be placed into the title bar/topic effectively pushing text upwards and with 2 or more /n chars the text is completely gone, \n chars should be removed from the titlebar/topic.

[poy (poy)]

old patch and discussion that might be relevant: <http://sourceforge.net/mailarchive/forum.php?thread_name=30BC2B6E7B2F4EAFA259223AF60A696E%40Zouzou&forum_name=dcplusplus-devel>

[iceman50 (bdcdevel)]

The problem isn't that DC++ accepts \n as a valid char, the problem is that it should filter it from making a new line i.e for every \n the text moves up on the titlebar, after two new line chars all you can see is the bottoms of certain chars. Attaching a png that shows the effect

[eMTee (realprogger)]

In theory poy's patches (not available in sf anymore) should fix this problem for ADC and some solution can be added for nmdc, too.
Poy, can you add those patches here so we can test them?

[poy (poy)]

here are the old patches. the ADCH++ one won't apply; it should be applied to adchppd.cpp instead.
with the latest DC++ and ADCH++, i can still reproduce the space in the hub name easily (should be forbidden), but not a new line; so there may already be some sanitization going on.
note that to test with ADCH++, one must disable scripts as they implement their own validation of the hub name and description.

[eMTee (realprogger)]

I cannot find any code for sanitization in ADCH++ (r516) and indeed it accepts the new lines for name and description...

[eMTee (realprogger)]

Here's the patch for the current ADCH++ head rev.

[Pirre (pierreparys)]

seems the lua validation catches the problem as far ADCH is concerned ...