gcommit fails with "Unknown error" if NoWhoami is raised

[Andrew Bennetts]

If you have no whoami information set, and try to commit with gcommit, you get an "Unknown error". At the same time you get warnings on the terminal:

/home/andrew/code/bzr-gtk/dialog.py:36: GtkWarning: Failed to set text from markup due to error parsing markup: Error on line 3 char 47: '<email address hidden>' is not a valid name: '@'
  dialog.format_secondary_markup(secondary)
/home/andrew/code/bzr-gtk/dialog.py:37: GtkWarning: Failed to set text from markup due to error parsing markup: Error on line 3 char 47: '<email address hidden>' is not a valid name: '@'
  response = dialog.run()

Note that '<email address hidden>' appears in the text description of NoWhoami.

Here's a fairly easy way to reproduce:

mkdir /tmp/fake_home
bzr init /tmp/a-branch
cd /tmp/a-branch
export EMAIL=
BZR_HOME=/tmp/fake_home bzr gcommit

Enter a commit message and click "Commit".

Presumably the fix involves making bzr-gtk formatting the error text differently?

As a secondary issue, it would be nice for "Unknown Error" situations to at least dump a traceback to stderr or something, rather than leave no clues.

[Jelmer Vernooij (jelmer)]

We shouldn't be using markup in the error dialogs - we don't know what text is going to be in bzr exceptions.