UnapprovedRevisions check can always return False
Bug #656525 reported by
dobey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Tarmac |
Fix Released
|
Critical
|
dobey | ||
Bug Description
It appears that there was recently a change in LP that switched the reviewed_revid attribute on merge proposals from being the revno, to being the revision id. Since the "tip" value we're using to compare with, is the revno, Python always compares it as larger than the revid. For example:
>>> 1 > "zzzzzzz-
False
We need to canonicalize to revno for comparison here.
Related branches
lp:~dobey/tarmac/revno-not-revid
- Paul Hummer: Approve
-
Diff: 53 lines (+26/-9)2 files modifiedtarmac/bin/commands.py (+7/-2)
tarmac/tests/test_commands.py (+19/-7)
| Changed in tarmac: | |
| status: | In Progress → Fix Committed |
| Changed in tarmac: | |
| milestone: | none → tarmac-0.5 |
| Changed in tarmac: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
