bug in account/account.py

[Leigh Willard]

There is at least one place that calls post without a context, which causes the routine to crash.

Here is the BEFORE:

def post(self, cr, uid, ids, context=None):
        invoice = context.get('invoice', False)

(note that context gets set to None by default)

Here is the FIX:

def post(self, cr, uid, ids, context={}):
        invoice = context.get('invoice', False)

[Cristian Salamea (ovnicraft)]

hi could be better
def post(self, cr, uid, ids, context=None):
    if context == None:
        context = {}

Regards

[Borja López Soilán (NeoPolus) (borjals)]

I would propose:
-------------------------
def post(self, cr, uid, ids, context=None):
    if context is None:
        context = {}
------------------------

That would match the code conventions stated here: http://doc.openerp.com/developer/Appendices/code_convention.html

[Cristian Salamea (ovnicraft)]

i am agree with Borja.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Thanks guys,
it has been fixed by revision 4241 <email address hidden>.