Terms and conditions text should not be broken up for translation
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Single Sign On Client |
Fix Released
|
Medium
|
Natalia Bidart | ||
Ubuntu Translations |
Fix Released
|
Medium
|
Unassigned | ||
ubuntu-sso-client (Ubuntu) |
Fix Released
|
Medium
|
Natalia Bidart |
Bug Description
At the bottom of the SSO login dialog there is a message asking the user if he/she accepts the Ubuntu One Terms and conditions.
It is composed of two translatable strings:
YES_TO_TC = _('I agree with the %(app_name)s ') # Terms&Conditions button
TC = _('Terms & Conditions')
The string should not be split. This makes it impossible to provide a good translation. In many languages the order needs to be rearranged to make it grammatically correct.
A couple of examples:
In Catalan:
* Current translation (incorrect): "Estic d'acord amb Ubuntu One Condicions generals"
* A correct translation: "Estic d'acord amd les condicions generals de l'Ubuntu One"
In Spanish:
* Current translation (incorrect): "Estoy de acuerdo con Ubuntu One Términos y condiciones"
* A correct translation: "Estoy de acuerdo con los términos y condiciones de Ubuntu One"
For more info on tips for i18n development and suggestions, see [1].
Thanks!
[1] http://
Related branches
- John Lenton (community): Approve
- David Planella (community): Approve
-
Diff: 307 lines (+58/-51)6 files modifieddata/ui.glade (+46/-43)
ubuntu_sso/credentials.py (+2/-0)
ubuntu_sso/gui.py (+4/-5)
ubuntu_sso/main.py (+1/-1)
ubuntu_sso/tests/test_credentials.py (+3/-0)
ubuntu_sso/tests/test_gui.py (+2/-2)
description: | updated |
Changed in ubuntu-translations: | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in ubuntu-sso-client: | |
status: | Triaged → Fix Committed |
Changed in ubuntu-sso-client (Ubuntu): | |
status: | Triaged → Fix Committed |
Changed in ubuntu-sso-client (Ubuntu): | |
status: | Fix Committed → Triaged |
milestone: | none → natty-alpha-1 |
Changed in ubuntu-sso-client (Ubuntu): | |
status: | Triaged → Fix Released |
Changed in ubuntu-sso-client: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-translations: | |
status: | Triaged → Fix Released |
I agree this needs to be fixed. Though I'm not sure about the fix since as per the design we needed to have the "Terms & Conditions" be a link button.
Maybe we can do something like:
<checkbox> _("I agree to the Ubuntu One Terms and Conditions") <button>Click here to browse them</button>